Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show link on result page #687

Closed
matthiaskomarek opened this issue Feb 27, 2018 · 2 comments
Closed

Show link on result page #687

matthiaskomarek opened this issue Feb 27, 2018 · 2 comments

Comments

@matthiaskomarek
Copy link
Contributor

Hey @garris,

first i would like to thank you for this great tool.

It would be nice if there would be a link to the url of the scenario on the "BackstopJS Report" page, to quickly check whats the problem on the tested page. Maybe under the "Text info" panel.

I would like to create a PR for this, if you are interested in this feature.

Thanks
@garris
Copy link
Owner

garris commented Feb 27, 2018

Sounds good!

matthiaskomarek added a commit to matthiaskomarek/BackstopJS that referenced this issue Mar 2, 2018
@matthiaskomarek
feat(VisualReport): add url and reference url to TextDetails Component
e740f2e 
feat(Chromy): add scenario url and reference url to test pair

resolve garris#687
@matthiaskomarek
Copy link
Contributor Author

Hey @garris i would kindly follow up on this issue. I have already created a PR, would be nice if you could take a look on this.

@garris garris closed this as completed in 51e15ff Mar 16, 2018
garris added a commit that referenced this issue Mar 23, 2018
@garris
Squashed commit of the following:
8639459 
commit 142dddd
Author: Garris Shipon <garris@me.com>
Date:   Fri Mar 23 15:13:06 2018 -0700

    update backstop_features reference

commit 20d0938
Author: Garris Shipon <garris@me.com>
Date:   Fri Mar 23 14:40:32 2018 -0700

    3.1.21

commit c02006c
Author: Garris Shipon <garris@me.com>
Date:   Fri Mar 23 14:39:43 2018 -0700

    fix broken scrubber

commit e321519
Author: Garris Shipon <garris@me.com>
Date:   Thu Mar 22 12:32:48 2018 -0700

    3.1.20

commit 578842a
Author: Garris Shipon <garris@me.com>
Date:   Thu Mar 22 12:32:25 2018 -0700

    improve report printing

    - Add page-break rule for result cards.
    - Also added documentation for working

commit 51e15ff
Author: Matthias Komarek <register@big-o-one.de>
Date:   Fri Mar 16 16:07:06 2018 +0100

    Feature/show url on text details component (#693)

    * feat(VisualReport): add url and reference url to TextDetails Component
    feat(Chromy): add scenario url and reference url to test pair

    resolve #687

    * remove typo

    * skip: update design, rearrange TextDetails and UrlDetails

commit 643e9b0
Author: Enikő Nagy <eenagy@users.noreply.github.com>
Date:   Fri Mar 16 06:42:47 2018 +0100

    add promise to approve (#642)
garris added a commit that referenced this issue Mar 28, 2018
@garris
add puppeteer support — by @krisdigital
72d0b05 
commit e8362eae583904f11926a7203fd7399dcd74ca8e
Author: Garris Shipon <garris@me.com>
Date:   Tue Mar 27 16:41:26 2018 -0700

    feature test refs

commit 9407831
Author: Christopher Frank <social@krisdigital.com>
Date:   Tue Mar 27 23:53:24 2018 +0200

    Improve Puppeteer error handling (#718)

    * Fix Smoke Test

    * Add error images for
    * not visible,
    * not found
    * and other errors

    * Catch and handle common puppet errors

    * Add missing translate url

    * Better forEach review

commit a2fc2d6
Author: Garris Shipon <garris@me.com>
Date:   Mon Mar 26 23:16:59 2018 -0700

    update error state graphics

    -notFound
    -notVisible
    -unexpectedError

commit cf3254a
Author: Garris Shipon <garris@me.com>
Date:   Sun Mar 25 19:05:12 2018 -0700

    increase backstop_features asyncCaptureLimit to 5

commit 0578a17
Author: Christopher Frank <social@krisdigital.com>
Date:   Sun Mar 25 20:04:46 2018 +0200

    Add debugWindow option to puppeteer (#713)

    * Add debugWindow option to puppeteer

    * Fix Smoke Test

commit 573d8f7
Author: Garris Shipon <garris@me.com>
Date:   Fri Mar 23 19:14:49 2018 -0700

    3.2.1

commit 1b571c3
Author: Garris Shipon <garris@me.com>
Date:   Fri Mar 23 19:14:12 2018 -0700

    add relative file handling for puppeteer option

commit cde25ea
Author: Garris Shipon <garris@me.com>
Date:   Fri Mar 23 16:11:43 2018 -0700

    update backstop_features test to puppeteer

    Seems to be an issue with relative paths.

commit 8639459
Author: Garris Shipon <garris@me.com>
Date:   Fri Mar 23 15:31:18 2018 -0700

    Squashed commit of the following:

    commit 142dddd
    Author: Garris Shipon <garris@me.com>
    Date:   Fri Mar 23 15:13:06 2018 -0700

        update backstop_features reference

    commit 20d0938
    Author: Garris Shipon <garris@me.com>
    Date:   Fri Mar 23 14:40:32 2018 -0700

        3.1.21

    commit c02006c
    Author: Garris Shipon <garris@me.com>
    Date:   Fri Mar 23 14:39:43 2018 -0700

        fix broken scrubber

    commit e321519
    Author: Garris Shipon <garris@me.com>
    Date:   Thu Mar 22 12:32:48 2018 -0700

        3.1.20

    commit 578842a
    Author: Garris Shipon <garris@me.com>
    Date:   Thu Mar 22 12:32:25 2018 -0700

        improve report printing

        - Add page-break rule for result cards.
        - Also added documentation for working

    commit 51e15ff
    Author: Matthias Komarek <register@big-o-one.de>
    Date:   Fri Mar 16 16:07:06 2018 +0100

        Feature/show url on text details component (#693)

        * feat(VisualReport): add url and reference url to TextDetails Component
        feat(Chromy): add scenario url and reference url to test pair

        resolve #687

        * remove typo

        * skip: update design, rearrange TextDetails and UrlDetails

    commit 643e9b0
    Author: Enikő Nagy <eenagy@users.noreply.github.com>
    Date:   Fri Mar 16 06:42:47 2018 +0100

        add promise to approve (#642)

commit d05c490
Author: Garris Shipon <garris@me.com>
Date:   Tue Mar 20 11:14:40 2018 -0700

    3.2.0

commit ec8949a
Author: Christopher Frank <social@krisdigital.com>
Date:   Mon Mar 19 17:37:59 2018 +0100

    Add Chromy Features to Puppeteer (#705)

    * Added functionality to shoot selectors with or without selector expansion

    * Let Puppeteer and chromy coexist and start cleaning up

    * forgot console.log

commit 3367b88
Author: krisdigital <info@krisdigital.com>
Date:   Thu Mar 15 22:33:55 2018 +0100

    Move Puppeteer to dependencies

commit 4b91ff8
Author: krisdigital <info@krisdigital.com>
Date:   Thu Mar 15 21:10:39 2018 +0100

    Add Puppeteer engine scripts

commit 88e1211
Author: krisdigital <info@krisdigital.com>
Date:   Thu Mar 15 20:37:23 2018 +0100

    Implement missing Puppet functions

commit b4213d9
Author: Christopher Frank <christopherfrank@Mac-Pro-3.local>
Date:   Thu Mar 15 17:39:21 2018 +0100

    Replace Chromy with Puppeteer
garris pushed a commit that referenced this issue Apr 14, 2018
@krisdigital @garris
Improve on Puppeteer error handling (#733)
483d8e3 
* Replace Chromy with Puppeteer

* Implement missing Puppet functions

* Add Puppeteer engine scripts

* Move Puppeteer to dependencies

* Add Chromy Features to Puppeteer (#705)

* Added functionality to shoot selectors with or without selector expansion

* Let Puppeteer and chromy coexist and start cleaning up

* forgot console.log

* 3.2.0

* Squashed commit of the following:

commit 142dddd
Author: Garris Shipon <garris@me.com>
Date:   Fri Mar 23 15:13:06 2018 -0700

    update backstop_features reference

commit 20d0938
Author: Garris Shipon <garris@me.com>
Date:   Fri Mar 23 14:40:32 2018 -0700

    3.1.21

commit c02006c
Author: Garris Shipon <garris@me.com>
Date:   Fri Mar 23 14:39:43 2018 -0700

    fix broken scrubber

commit e321519
Author: Garris Shipon <garris@me.com>
Date:   Thu Mar 22 12:32:48 2018 -0700

    3.1.20

commit 578842a
Author: Garris Shipon <garris@me.com>
Date:   Thu Mar 22 12:32:25 2018 -0700

    improve report printing

    - Add page-break rule for result cards.
    - Also added documentation for working

commit 51e15ff
Author: Matthias Komarek <register@big-o-one.de>
Date:   Fri Mar 16 16:07:06 2018 +0100

    Feature/show url on text details component (#693)

    * feat(VisualReport): add url and reference url to TextDetails Component
    feat(Chromy): add scenario url and reference url to test pair

    resolve #687

    * remove typo

    * skip: update design, rearrange TextDetails and UrlDetails

commit 643e9b0
Author: Enikő Nagy <eenagy@users.noreply.github.com>
Date:   Fri Mar 16 06:42:47 2018 +0100

    add promise to approve (#642)

* update backstop_features test to puppeteer

Seems to be an issue with relative paths.

* add relative file handling for puppeteer option

* 3.2.1

* Add debugWindow option to puppeteer (#713)

* Add debugWindow option to puppeteer

* Fix Smoke Test

* increase backstop_features asyncCaptureLimit to 5

* update error state graphics

-notFound
-notVisible
-unexpectedError

* Fix Smoke Test

* Add error images for
* not visible,
* not found
* and other errors

* Catch and handle common puppet errors

* Add missing translate url

* Better forEach review

* Better error handling for Puppeteer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garris @matthiaskomarek