Improve on Puppeteer error handling #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added functionality to shoot selectors with or without selector expansion * Let Puppeteer and chromy coexist and start cleaning up * forgot console.log
commit 142dddd Author: Garris Shipon <garris@me.com> Date: Fri Mar 23 15:13:06 2018 -0700 update backstop_features reference commit 20d0938 Author: Garris Shipon <garris@me.com> Date: Fri Mar 23 14:40:32 2018 -0700 3.1.21 commit c02006c Author: Garris Shipon <garris@me.com> Date: Fri Mar 23 14:39:43 2018 -0700 fix broken scrubber commit e321519 Author: Garris Shipon <garris@me.com> Date: Thu Mar 22 12:32:48 2018 -0700 3.1.20 commit 578842a Author: Garris Shipon <garris@me.com> Date: Thu Mar 22 12:32:25 2018 -0700 improve report printing - Add page-break rule for result cards. - Also added documentation for working commit 51e15ff Author: Matthias Komarek <register@big-o-one.de> Date: Fri Mar 16 16:07:06 2018 +0100 Feature/show url on text details component (garris#693) * feat(VisualReport): add url and reference url to TextDetails Component feat(Chromy): add scenario url and reference url to test pair resolve garris#687 * remove typo * skip: update design, rearrange TextDetails and UrlDetails commit 643e9b0 Author: Enikő Nagy <eenagy@users.noreply.github.com> Date: Fri Mar 16 06:42:47 2018 +0100 add promise to approve (garris#642)
Seems to be an issue with relative paths.
* Add debugWindow option to puppeteer * Fix Smoke Test
-notFound -notVisible -unexpectedError
* not visible, * not found * and other errors
# Conflicts: # README.md # core/util/runPuppet.js # package-lock.json # package.json
garris
approved these changes
Apr 14, 2018
|
@krisdigital This is super -- thank you for fixing! I just added some more error handling so that if any of the scenario interactions fail we will see the correct error graphic. I've also added any engine errors to the report data -- so now the exception data is actually making it to the browser report. Next is to add the exception data to the layout. I will try to get to that soon. Thanks again for all your help. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should behave like Chromy now..