Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mangata dev v0.9.31 #76

Merged
merged 173 commits into from
Dec 31, 2022
Merged

Mangata dev v0.9.31 #76

merged 173 commits into from
Dec 31, 2022

Conversation

devdanco
Copy link
Member

No description provided.

athei and others added 30 commits September 7, 2022 14:49
@athei
Update contract weights (paritytech#12192)
021f712 
* Dummy commit

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

Co-authored-by: command-bot <>
@KiChjang
Move Get and bounded types to sp-core (paritytech#12203)
5e2ffeb 
* Move Get and bounded types to sp-core

* Fixes

* cargo fmt

* Fixes
@ggwpez @bkchr
Add --header to benchmark overhead + storage (paritytech#12204)
c0e1cdb 
* Add header to 'overhead' command

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add header to 'storage' command

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update READMEs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <info@kchr.de>

* .as_ref() and fmt

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <info@kchr.de>
@KiChjang @ggwpez @athei
Remove Ord impl for Weights V2 and add comparison fns (paritytech#12183)
2619394 
* Remove Ord impl for Weights V2 and add comparison fns

* Remove TODO

* Update frame/multisig/src/lib.rs

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update frame/election-provider-multi-phase/src/unsigned.rs

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Remove unused import

* cargo fmt

* Fix tests

* Fix more tests

* cargo fmt

* Fix more tests

* Update frame/contracts/src/wasm/mod.rs

Co-authored-by: Alexander Theißen <alex.theissen@me.com>

* Update weight benchmarking templates

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
@bkchr
pallet-identity: Be more paranoid ;) (paritytech#12170)
8075aa4 
* pallet-identity: Be more paranoid ;)

Check that a registrar is providing judgement for the correct identity.

* Fixes

* Fix alliance

* 🤦

* Fixes

* ...
@bkchr @athei
Upgrade wasmtime to 0.40.0 (paritytech#12096)
e202092 
* Upgrade wasmtime to 0.40.0

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

* Update in the other Cargo.toml

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

Co-authored-by: command-bot <>
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
@tifecool @kianenigma
Use parameter_types instead of thread_local for test-setup (paritytec…
0478535 
…h#12036)

* Edit to Assets. parameter_types

* fixes

* Test Fixes. WIP

* Edits to pallet-aura

* Camel Case

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Implementation of mutate fn

* update to pallet-aura

* Update to frame-system. Fixes

* Update to frame-support-test. CamelCases

* Updates to frame- contracts, offences, staking, bounties, child bounties

* Edit to mutate fn. Changes to frame-contracts. CamelCase pallet-aura

* Edits to frame-contracts & executive

* cargo +nightly fmt

* unused import removed

* unused import removed

* cargo +nightly fmt

* minor adjustment

* updates

* updates

* cargo +nightly fmt

* cargo +nightly fmt

* take fn implemented

* update

* update

* Fixes to CallFilter

* cargo +nightly fmt

* final fixes

* Default changed to $value

* Update frame/support/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@rcny @alvicsam
Fully remove rusty-cachier from the node-bench-regression-guard j…
cd66db5 
…ob (paritytech#11904)

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
@athei
Upgrade wasm crate dependencies (paritytech#12173)
b8c3d8c 
* Upgrade wasm crate dependencies

* New wasmi version changed error output a bit

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

Co-authored-by: command-bot <>
@hbulgarini
Removing without_storage_info from scored-pool pallet. (paritytech#11996
f9fdee1 
)

* Removing without_storage_info from scored-pool pallet.

* Addressing PR feedback

* typo

* typo

* Addressing PR comments and formatting code

* Removing unwanted import

* Adding a map_err

* cargo fmt

Co-authored-by: parity-processbot <>
@MOZGIII
Update ss58-registry (paritytech#12220)
c8bfc91
Add missing metadata specs to crate manifests (paritytech#12221)
5a48536 
Some crates were missing repository or description specs, which are
required for publishing crates with cargo unleash.
@bkchr
construct_runtime: Fix generation of types behind features (paritytec…
51f60d0 
…h#12229)

* construct_runtime: Fix generation of types behind features

With the recent addition of supporting features in `construct_runtime!` there was a bug overseen.
The `AllPalletsWithSystem` etc type declarations would be declared twice when a certain was enabled.
The problem was that in the macro we didn't feature gate the types that should be declared when
there is no feature enabled. This pull request now takes care of feature gating this type behind
`all(#( not(feature) ))`. So, these types will only be enabled if no of the configured features is enabled.

* Fix tests

* FMT
@bkchr
Remove native call (paritytech#12201)
7de3d78 
* Remove native call

With the recent introduction of staging runtime apis the native call wasn't supported anymore. This
removes the entire support for this as it is not used anymore.

* FMT

* Fix benchmarks

* FIX ui tests
@kianenigma @ggwpez
Fuzz testing for nomination pools (paritytech#12002)
d5de897 
* some additional tests and stuff

* make sanity public

* add some sort of fuzz test for pools

* breaks every now and then

* breaks every now and then

* IT WORKS AND PASSES 100k TESTS

* cleanup

* safe id addition

* fix assert_eq_error_rate

* Update frame/nomination-pools/src/tests.rs

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update frame/nomination-pools/src/tests.rs

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* add some doc

* Fix

* ".git/.scripts/fmt.sh" 1

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
@mrshiposha
Add ConstFeeMultiplier to the transaction payment pallet (paritytec…
c997a62 
…h#12222)

* fix: FeeMultiplierUpdate

* fix: cargo fmt

* fix: rustdoc

* Revert "fix: rustdoc"

This reverts commit 96b6ad8.

* Revert "fix: cargo fmt"

This reverts commit 1301652.

* Revert "fix: FeeMultiplierUpdate"

This reverts commit 2cbddd0.

* feat: add ConstFeeMultiplier

* fix: use cConstFeeMultiplier in the template node
@rcny
Don't run cargo-check-benches for master based downstream staging…
7cb78ff 
… pipelines (paritytech#12233)
@kianenigma @BustaNit
Expose some of the staking miner types over metadata (paritytech#12245)
dd1f1b5 
* Expose some of the staking miner types over metadata

* Update frame/election-provider-multi-phase/src/lib.rs

Co-authored-by: Emily Ostbo <47109040+EmilyOstbo@users.noreply.github.com>

Co-authored-by: Emily Ostbo <47109040+EmilyOstbo@users.noreply.github.com>
@yjhmelody
extract some grandpa types to Primitives crate (paritytech#12208)
f1c60e5 
* extract some grandpa types to primitives

* fmt

* fmt
@Szegoo @shawntabrizi
BREAKING: Rename Call & Event (paritytech#11981)
5527263 
* rename Event to RuntimeEvent

* rename Call

* rename in runtimes

* small fix

* rename Event

* small fix & rename RuntimeCall back to Call for now

* small fixes

* more renaming

* a bit more renaming

* fmt

* small fix

* commit

* prep for renaming associated types

* fix

* rename associated Event type

* rename to RuntimeEvent

* commit

* merge conflict fixes & fmt

* additional renaming

* fix.

* fix decl_event

* rename in tests

* remove warnings

* remove accidental rename

* .

* commit

* update .stderr

* fix in test

* update .stderr

* TRYBUILD=overwrite

* docs

* fmt

* small change in docs

* rename PalletEvent to Event

* rename Call to RuntimeCall

* renamed at wrong places :P

* rename Call

* rename

* rename associated type

* fix

* fix & fmt

* commit

* frame-support-test

* passing tests

* update docs

* rustdoc fix

* update .stderr

* wrong code in docs

* merge fix

* fix in error message

* update .stderr

* docs & error message

* .

* merge fix

* merge fix

* fmt

* fmt

* merge fix

* more fixing

* fmt

* remove unused

* fmt

* fix

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
@nuke-web3
Update README (paritytech#12247)
379813c 
* Update README

- rm Matrix chat banner reads as `inaccessible` and the channel is read only (not chat)
- add SE banner
- update links & call to action to SE

* Update README.md

* Update README.md

* Update README.md
@girazoki @shawntabrizi
Add inspect trait for asset roles (paritytech#11738)
5daa20c 
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
@altonen
Move bitswap to its own crate (paritytech#12242)
c1103fd 
* Introduce `sc-network-bitswap`

Move the bitswap protocol out of `sc-network` to its own crate.

* Improve test coverage

* Remove mention of bitswap from `sc-network`

* Fix documentation

* Fix clippy and remove the void dependency

* Remove unneeded trait bound and bump prost to 0.11
@ggwpez @bkchr
benches: disable caching per default (paritytech#12232)
9df9448 
* Disable cache for storage benches

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Disable caching per default

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update utils/frame/benchmarking-cli/src/storage/cmd.rs

Co-authored-by: Bastian Köcher <info@kchr.de>

* Add --enable-trie-cache to 'storage' command

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <info@kchr.de>
@bkchr @koute @BustaNit
Make BasePath::new_temp_dir return the same path for the program li…
bb7fb64 
…fetime (paritytech#12246)

* Make `BasePath::new_temp_dir` return the same path for the program lifetime

Instead of returning always a different path, this now returns the same path for the entire lifetime
of the program. We still ensure that the path is cleared at the end of the program.

* Update client/service/src/config.rs

Co-authored-by: Koute <koute@users.noreply.github.com>

* Update client/service/src/config.rs

Co-authored-by: Nitwit <47109040+nitwit69@users.noreply.github.com>

* FMT

Co-authored-by: Koute <koute@users.noreply.github.com>
Co-authored-by: Nitwit <47109040+nitwit69@users.noreply.github.com>
@michalkucharczyk
Remove CanAuthorWith trait (paritytech#12213)
3449fb0 
* Remove CanAuthorWith trait

CanAuthotWith trait removed. Also all dependencies, parameters, type
paramers were removed. This is related to removal of native runtime.

* Remove commented code

* Fix code formatting

* trigger CI job

* trigger CI job

* trigger CI job

* trigger CI job

* trigger CI job

* trigger CI job

* trigger CI job
@KiChjang @shawntabrizi @kianenigma
Create sp-weights crate to store weight primitives (paritytech#12219)
23bb5a6 
* Create sp-weights crate to store weight primitives

* Fix templates

* Fix templates

* Fixes

* Fixes

* cargo fmt

* Fixes

* Fixes

* Use deprecated type alias instead of deprecated unit types

* Use deprecated subtraits instead of deprecated hollow new traits

* Fixes

* Allow deprecation in macro expansion

* Add missing where clause during call macro expansion

* cargo fmt

* Fixes

* cargo fmt

* Fixes

* Fixes

* Fixes

* Fixes

* Move FRAME-specific weight files back to frame_support

* Fixes

* Update frame/support/src/dispatch.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update frame/support/src/dispatch.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update frame/support/src/dispatch.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Add missing header

* Rewrite module docs

* Fixes

* Fixes

* Fixes

* Fixes

* cargo fmt

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@shawntabrizi
fix sp-weight std (paritytech#12265)
b5e2542
@koute @shawntabrizi
Improve base weights consistency and make sure they're never zero (pa…
7c2c0c1 
…ritytech#11806)

* Improve base weights consistency and make sure they're never zero

* Switch back to `linregress` crate; add back estimation errors

* Move the test into `mod tests`

* Use all of the samples instead of only the first one

* Use full precision extrinsic base weights and slopes

* Add an extra comment

* ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts

Co-authored-by: parity-processbot <>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
@ggwpez
Fix Rust features (paritytech#11976)
dc22e48 
* Add std feature

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix features

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* WIP

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix features

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fmt

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix features

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Cleanup

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Impl function also in tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Make compile

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix sp-trie feature

Something makes the bench regression guard fail, maybe this?

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add runtime-benchmarks feature to sc-service

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Revert "Fix sp-trie feature"

This reverts commit f2cddfe.
Was already fixed, only needed a CI retry.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
skunert and others added 21 commits October 18, 2022 06:52
@skunert @bkchr
Bump clap to 4.0.x and adjust to best practices (paritytech#12381)
e8a4408 
* Bump clap to 3.2.22

* Replace `from_os_str` with `value_parser`

* Replace `from_str` and `try_from_str` with `value_parser`

* Move possible_values to the new format

* Remove unwanted print

* Add missing match branch

* Update clap to 4.0.9 and make it compile

* Replace deprecated `clap` macro with `command` and `value`

* Move remaining `clap` attributes to `arg`

* Remove no-op value_parsers

* Adjust value_parser for state_version

* Remove "deprecated" feature flag and bump to 4.0.11

* Improve range

Co-authored-by: Bastian Köcher <git@kchr.de>

* Apply suggestions

* Trigger CI

* Fix unused error warning

* Fix doc errors

* Fix ArgGroup naming conflict

* Change default_value to default_value_t

* Use 1.. instead of 0..

Co-authored-by: Bastian Köcher <git@kchr.de>
@dharjeezy
implement storage decode length for BTreeSet (paritytech#12503)
b9a555d 
* implement storage decode length for BTreeSet

* Orderly moving of things around

* include test for append and decode_len

* fix cargo clippy issue
@tomaka @bkchr
Decrease default --out-peers from 25 to 15 (paritytech#12434)
415648d 
Co-authored-by: Bastian Köcher <git@kchr.de>
@bkchr
Prepare for latest clippy (nightly 09-10-2022) (paritytech#12466)
4c45673
@serban300
derive Serialize/Deserialize for BeefyAuthoritySet (paritytech#12516)
281bcd4
@michalkucharczyk @bkchr @dmitry-markin
BlockId removal: refactor: StorageProvider (paritytech#12510)
e34b840 
* BlockId removal: refactor: StorageProvider

It changes the arguments of `Backend::StorageProvider` trait from:
block: `BlockId<Block>` to: hash: `&Block::Hash`

This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <git@kchr.de>

* Update client/api/src/backend.rs

Co-authored-by: Dmitrii Markin <dmitry@markin.tech>

* GrandpaBlockImport::current_set_id reworked

* ExportStateCmd reworked

* trigger CI job

* trigger CI job

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Dmitrii Markin <dmitry@markin.tech>
@skunert
Use ArgAction::Set for enable-offchain-indexing flag (paritytech#12521
487ac5c 
)

* Use ArgAction::Set for enable-offchain-indexing

* Provide default value for `enable-offchain-indexing`
@niklasad1 @kianenigma
frame/utils: introduce substrate-rpc-client crate for RPC utils (pa…
49734dd 
…ritytech#12212)

* hack together a PoC

* Update utils/frame/rpc-utils/Cargo.toml

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update utils/frame/rpc-utils/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* rpc_utils -> substrate_rpc_client

* try runtime: remove keep connection

* make CI happy

* cargo fmt

* fix ci

* update lock file

* fix

* fix

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: kianenigma <kian@parity.io>
@koute @ggwpez @coderobe
Force base weights to be the minimum only when the intercept is negat…
399ab89 
…ive (paritytech#12482)

* Force base weights to be the minimum only when the intercept is negative; emit minimum execution times

* Add an `assert` making sure the intercept is zero when it's supposed to be zero

* Fix template

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* ".git/.scripts/bench-bot.sh" pallet dev pallet_assets

* ".git/.scripts/bench-bot.sh" pallet dev pallet_uniques

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
@ggwpez @shawntabrizi @coderobe
Update pallet-multisig benches (paritytech#12558)
7a4e516 
* Typo

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* ".git/.scripts/bench-bot.sh" pallet dev pallet_multisig

* remove functions

* ".git/.scripts/bench-bot.sh" pallet dev pallet_multisig

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
@devdanco
resolve conflicts version 31
7eab46f
@devdanco
Update TargetedFeeAdjustment struct
6304e5a
@devdanco
Merge branch 'mangata-dev' into mangata-dev-v0.9.31
1dfd9b4
@devdanco
add feature to crate
c2f6367
@devdanco
update orml version in test
1f23be6
@devdanco
remove unnecessary try-runtime feature
f61d829
@devdanco
feat: resolve confclits and fix fmt
3696593
@devdanco
fix: benchmarking types
b31aa9d
@devdanco
Merge branch 'mangata-dev' into mangata-dev-v0.9.31
7b6b521
@devdanco
feat: resolve conflicts after storage queue
c5a1bbe
@devdanco
fix: tests
34c492c
mateuszaaa
mateuszaaa reviewed Dec 30, 2022
View reviewed changes
client/consensus/slots/src/lib.rs
let claim = self.claim_slot(&slot_info.chain_head, slot, &epoch_data).await?;
let key = self.get_key(&claim);
inject_inherents(keystore, &key, &mut slot_info).ok()?;
let claim = self.claim_slot(&slot_info.chain_head, slot, &aux_data).await?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the inheret injection part is very important and should not be removed

@devdanco devdanco merged commit 902813c into mangata-dev Dec 31, 2022
mateuszaaa pushed a commit that referenced this pull request Jan 4, 2023
@devdanco @mateuszaaa
Merge pull request #76 from mangata-finance/mangata-dev-v0.9.31
369ed5c 
Mangata dev v0.9.31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszaaa mateuszaaa mateuszaaa left review comments

@iStrike7 iStrike7 Awaiting requested review from iStrike7

Assignees
No one assigned
Labels
A0-pleasereview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.