This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
implement storage decode length for BTreeSet #12503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Oct 16, 2022
frame/support/src/storage/mod.rs
Outdated
| @@ -1335,6 +1337,10 @@ mod private { | |||
| impl<T: Encode> StorageAppend<T> for Vec<T> {} | |||
| impl<T: Encode> StorageDecodeLength for Vec<T> {} | |||
|
|
|||
| impl<T: Encode> Sealed for BTreeSet<T> {} | |||
There was a problem hiding this comment.
Can you please move this to the other implementations?
frame/support/src/storage/mod.rs
Outdated
| pub use sp_runtime::TransactionOutcome; | ||
| use sp_std::collections::btree_set::BTreeSet; |
There was a problem hiding this comment.
Above we already include sp_std. Please move it there.
ggwpez
reviewed
Oct 17, 2022
ggwpez
reviewed
Oct 17, 2022
bkchr
approved these changes
Oct 17, 2022
ggwpez
approved these changes
Oct 17, 2022
ggwpez
added
A0-please_review
|
Just need to make the CI happy now. You can click on the failing jobs, eg Clippy: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1958117 |
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* implement storage decode length for BTreeSet * Orderly moving of things around * include test for append and decode_len * fix cargo clippy issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implemnts
StorageDecodeLengthfor unboundedBTreeSetcloses #12443