Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

implement storage decode length for BTreeSet #12503

Merged
merged 4 commits into from
Oct 18, 2022
Merged

implement storage decode length for BTreeSet #12503

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9de0248
implement storage decode length for BTreeSet
dharjeezy Oct 16, 2022
27502a4
Orderly moving of things around
dharjeezy Oct 17, 2022
cc40700
include test for append and decode_len
dharjeezy Oct 17, 2022
b607786
fix cargo clippy issue
dharjeezy Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions frame/support/src/storage/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ pub use self::{
},
types::StorageEntryMetadataBuilder,
};
use crate::pallet_prelude::storage::private::Sealed;
dharjeezy marked this conversation as resolved.
Show resolved Hide resolved
pub use sp_runtime::TransactionOutcome;
use sp_std::collections::btree_set::BTreeSet;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above we already include sp_std. Please move it there.

pub use types::Key;

pub mod bounded_btree_map;
Expand Down Expand Up @@ -1335,6 +1337,10 @@ mod private {
impl<T: Encode> StorageAppend<T> for Vec<T> {}
impl<T: Encode> StorageDecodeLength for Vec<T> {}

impl<T: Encode> Sealed for BTreeSet<T> {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move this to the other implementations?

impl<T: Encode> StorageAppend<T> for BTreeSet<T> {}
impl<T: Encode> StorageDecodeLength for BTreeSet<T> {}

ggwpez marked this conversation as resolved.
Show resolved Hide resolved
/// We abuse the fact that SCALE does not put any marker into the encoding, i.e. we only encode the
/// internal vec and we can append to this vec. We have a test that ensures that if the `Digest`
/// format ever changes, we need to remove this here.
Expand Down