Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin scaffold CLI #51

Merged
merged 5 commits into from
May 17, 2024
Merged

Plugin scaffold CLI #51

merged 5 commits into from
May 17, 2024

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented May 10, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 9:35pm

@mostafa mostafa self-assigned this May 10, 2024
@mostafa mostafa mentioned this pull request May 10, 2024
Closed
4 tasks
zeina1i
zeina1i reviewed May 10, 2024
View reviewed changes
Copy link
Member

@zeina1i zeina1i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mostafa 🙏

It looks good to me,
I left a few comments, let's discuss when you have a chance.

developing-plugins/plugin-developers-guide.md Outdated Show resolved Hide resolved
developing-plugins/plugin-developers-guide.md Show resolved Hide resolved
developing-plugins/plugin-developers-guide.md Show resolved Hide resolved
developing-plugins/plugin-developers-guide.md Show resolved Hide resolved
developing-plugins/plugin-developers-guide.md Outdated Show resolved Hide resolved
developing-plugins/plugin-developers-guide.md Outdated Show resolved Hide resolved
@mostafa
Copy link
Member Author

mostafa commented May 11, 2024

@zeina1i Addressed your comments in 25268e3 and left some comments as well.

@mostafa mostafa requested a review from zeina1i May 11, 2024 21:37
zeina1i
zeina1i approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@zeina1i zeina1i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for new changes @mostafa 🙏
Approved 🚀

@mostafa
Copy link
Member Author

mostafa commented May 12, 2024

@zeina1i I'll merge it after releasing a new version of GatewayD.

@mostafa mostafa merged commit e3cb596 into main May 17, 2024
4 checks passed
@mostafa mostafa deleted the plugin-scaffold-cli branch May 17, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeina1i zeina1i zeina1i approved these changes

Assignees

@mostafa mostafa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mostafa @zeina1i