Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement plugin scaffold #518

Merged
merged 16 commits into from
Apr 28, 2024
Merged

Implement plugin scaffold #518

merged 16 commits into from
Apr 28, 2024

Conversation

zeina1i
Copy link
Member

@zeina1i zeina1i commented Apr 28, 2024 •
edited by mostafa
Loading

Ticket(s)

#475

Description

Implement plugin scaffold

Related PRs

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have updated docs using make gen-docs command.
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

mostafa
mostafa reviewed Apr 28, 2024
View reviewed changes
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeina1i Thanks for your contribution! 🙏

plugin/plugin_scaffold.go Outdated Show resolved Hide resolved
plugin/template/project/{{ plugin_name }}/.github/pull_request_template.md Outdated Show resolved Hide resolved
plugin/template/project/{{ plugin_name }}/.github/pull_request_template.md Outdated Show resolved Hide resolved
plugin/template/project/{{ plugin_name }}/.gitignore Outdated Show resolved Hide resolved
plugin/template/project/{{ plugin_name }}/gatewayd_plugin.yaml Outdated Show resolved Hide resolved
plugin/template/project/{{ plugin_name }}/gatewayd_plugin.yaml Outdated Show resolved Hide resolved
@zeina1i zeina1i changed the title WIP - Implement plugin scaffold Implement plugin scaffold Apr 28, 2024
@zeina1i zeina1i marked this pull request as draft April 28, 2024 14:32
@zeina1i zeina1i marked this pull request as ready for review April 28, 2024 21:04
mostafa
mostafa reviewed Apr 28, 2024
View reviewed changes
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a couple of comments to remove comments. 😆

plugin/plugin_scaffold.go Outdated Show resolved Hide resolved
plugin/plugin_scaffold.go Outdated Show resolved Hide resolved
mostafa
mostafa reviewed Apr 28, 2024
View reviewed changes
cmd/plugin_scaffold.go Outdated Show resolved Hide resolved
mostafa
mostafa approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeina1i Thanks for your awesome contribution! 🚀 🙏

@mostafa mostafa mentioned this pull request Apr 28, 2024
Closed
4 tasks
@mostafa mostafa merged commit a12d73e into gatewayd-io:main Apr 28, 2024
3 of 4 checks passed
This was referenced May 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostafa mostafa mostafa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeina1i @mostafa