Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gatewayd plugin scaffold CLI docs #528

Merged
merged 2 commits into from
May 11, 2024
Merged

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented May 10, 2024

Ticket(s)

Description

This PR update CLI docs.

FYI: @zeina1i

Related PRs

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have updated docs using make gen-docs command.
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

Copy link
Member

@zeina1i zeina1i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mostafa for updating the docs
Your PR looks good to me 👍

@mostafa mostafa merged commit 51bb3a4 into main May 11, 2024
4 checks passed
@mostafa mostafa deleted the gen-docs-for-plugin-scaffold branch May 11, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants