Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement (docs): Improvements to retext-spell #25290

Closed
20 of 21 tasks
tesseralis opened this issue Jun 25, 2020 · 46 comments
Closed
20 of 21 tasks

enhancement (docs): Improvements to retext-spell #25290

tesseralis opened this issue Jun 25, 2020 · 46 comments
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@tesseralis
Copy link
Contributor

tesseralis commented Jun 25, 2020

Overview

This issue is an overview of improvements to standardizing the spelling and formatting of words in our docs. Fixing these involves going to dictionary.txt and removing unneeded entries.

  1. put filenames like .htaccess in code blocks
  2. put code like inferInputObjectStrctureFromNodes in code blocks
  3. put names of packages (including gatsby plugins like gatsby-source-filesystem) in code blocks
  4. Standardize names of libraries and brands (for example, GraphQL instead of Graphql or graphQL)
  5. some image alt text in tutorial pages are just file names (e.g. ![with-layout2](with-layout2.png))

Note:

Upstream Changes

The following involve changes to retext itself and requires raising issues to that library:

  1. Improve handling of words with numbers in them. "1000px" should be treated as the tokens "1000" and "px".
  2. Improve handling of words-joined-with-dashes. These should be treated as individual words.
  3. Syntax for hashtags

Current Activities

@tesseralis tesseralis added help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation good first issue Issue that doesn't require previous experience with Gatsby labels Jun 25, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 25, 2020
@tesseralis
Copy link
Contributor Author

cc @muescha

@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 25, 2020
@robintom
Copy link

robintom commented Jun 25, 2020

Hi @tesseralis could you please assign this to me? I have been looking to do some open source contributions.

And I am somewhat confused on this issue, would you be able to provide more context for this?

@muescha
Copy link
Contributor

muescha commented Jun 25, 2020

@robintom since this issue is like an "umbrella" issue: the best is if you take only one small change at a time (for example put one package in code fences). this is more easy to approve a pull request.

anounce here which change you will do, so others can take an other one.

@FocalChord
Copy link
Contributor

FocalChord commented Jun 26, 2020

@muescha Hey I will be working on this issue. In particular this part:

  • put filenames like .htaccess in code blocks

Should I open a PR for this particular part and then reference this issue?

See my PR below. Is that alright? (It is my first time contributing so let me know :))

@muescha
Copy link
Contributor

muescha commented Jun 26, 2020

@FocalChord great! - i updated the issue text

@FocalChord
Copy link
Contributor

@muescha So for each other sub-issue do I make a seperate branch and then seperate PR?

Also when does the PR get merged in?

@muescha
Copy link
Contributor

muescha commented Jun 26, 2020

Hint: searching for text which is not already in code fences in files with RegEx (and File Mask *.md*)

[^`]some-thing[^`] 
[^`]\.htaccess[^`] // with dots

BTW: in WebStorm it shows you a section "Usage in comments" if the text is already in code blocks :)

@muescha
Copy link
Contributor

muescha commented Jun 26, 2020

yes - new branch and new PR

it takes some time to get merged, just be patient. the Gatsby team has to approve each PR and with smaller steps this is more easy to check :)

@FocalChord
Copy link
Contributor

@muescha Awesome! Thanks for this :) I'll work on the 2nd, 3rd, 4th bulletpoints soon.

@meyian
Copy link
Contributor

meyian commented Jun 27, 2020

Hello @muescha and @FocalChord, I'm new here and I'd like to help. Since the list is being tackled one bullet point at a time, I was thinking I could start on bullet point no. 5.

some image alt text in tutorial pages are just file names (e.g. ![with-layout2](with-layout2.png))

If I understand the task correctly, there are two parts to this:

  • Delete "with-layout2" and other similar lines from dictionary.txt
  • Go through the docs and give better alt text for those images

Do I have the right idea? But before then, is this even a ticket that's looking for help, or should I wait for the next one?

@tesseralis
Copy link
Contributor Author

@meyian Yup! We'd want to add better alt text to the images in the tutorial.

@muescha
Copy link
Contributor

muescha commented Jun 27, 2020

i would suggest (for expample for type 1) a PR should only remove one line per dictionary (or like in #25339 similar ones) so PR are small scoped and approved fast.

@muescha
Copy link
Contributor

muescha commented Jun 27, 2020

somehow it not catches all places?

i run the lint for #25355 but in not catches for the NPM in:

- helps you leverage open source innovations in the React, NPM, and Gatsby communities for your web projects

update: this is because the heading is marked as SourceNode, i think because of the slashes:

├─29 ParagraphNode
│   └─0 SentenceNode
│       └─0 SourceNode "Backbone.js/Node.js/NPM"

but this get catched:

Node.js, then only a couple of years old, was gaining traction fast. For the first time, NPM enabled the easy sharing of JavaScript libraries. Consequently, the number of libraries exploded. With a server runtime and ecosystem developing around JS, more and more web development tools started being written in JavaScript.

@gdstewart
Copy link

Hello! I wouldn't mind helping out too! I'd like to tackle 6 but I'm a bit confused about which imported components are being referred to, is it all imported components or only ones involving remark-mdx?

@ghost
Copy link

ghost commented Jun 30, 2020

if I understand this correctly, for point 7 we need to edit the dictionary.txt and spilt the text characters from the numbers. Similarly for point 8, we need to split the words with dashes to separate individual words.
Can I work on this :)

@muescha
Copy link
Contributor

muescha commented Jun 30, 2020

  1. try out if this working like this.

but:

  1. it is a more general change to the system and i think the hardest one...

(edit: because Markdown parser hier in the comment changed the numbers from 6 to 8 if it is one line behind the seven)

@ghost
Copy link

ghost commented Jun 30, 2020

okay, I'll start working on these.

@LekoArts LekoArts removed the stale? Issue that may be closed soon due to the original author not responding any more. label Sep 2, 2020
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Sep 24, 2020
@muescha
Copy link
Contributor

muescha commented Sep 24, 2020

not stale

@pattimcletchie
Copy link

@muescha is this still open and needing to be worked on?

@mwlai288
Copy link

mwlai288 commented Oct 8, 2020

@muescha anything still needs to be worked on?

@muescha
Copy link
Contributor

muescha commented Oct 8, 2020

Yes. There are still more words from dictionary.txt which can be touched (fixed/removed)

mwlai288 added a commit to mwlai288/gatsby that referenced this issue Oct 9, 2020
Placed gatsby-plugin-offline in code blocks. From issue gatsbyjs#25290 3. put names of packages (including gatsby plugins like gatsby-source-filesystem) in code blocks.
@chrysillala
Copy link

Hi @muescha, is this still open? Can I try to help? Thanks

@prathyushasai
Copy link

Hi @muescha, Can I work on serverless and s3? Or are those already taken?

@muescha
Copy link
Contributor

muescha commented Oct 22, 2020

Feel free to grab words from dictionary

(But exclude blog posts from the /blog folder)

@brandonbawe
Copy link

I just started using gatsby and happy to know that it is open source and I must say gatsby is amazing. Please I'd like to work on this issue.

@kadhirash
Copy link
Contributor

Hey @meganesu, does #27856 mean trying to work on this issue will be paused temporarily?

@LekoArts
Copy link
Contributor

I think the biggest areas of problems were solved and the last couple of PRs weren't worthwhile/improving things a lot. Hence I'll close this one as there are better "good first issue" in our log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

No branches or pull requests