-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(docs): Remove entries in dictionary.txt and fix alt text values in docs files #26022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @meyian! Thank you so much for this contribution! This is a really awesome improvement.
Would you mind removing any instances of "Screenshot of" in these files? I know we do it in several blog posts a few other places in the docs but it's generally not necessary information. Screen readers users will know these are images, so we don't need to repeat that each one is a screenshot in the alt text.
Also, it looks like we're still getting lint warnings for instances of "allFile".
Once that's done, I'm happy to have another look. Thanks again!
This comment has been minimized.
This comment has been minimized.
Sure thing! I've removed references to "allFile" and instances of "Screenshot of." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the "Screenshot of" in the docs files, the blog posts are not sourced from here anymore so it's something we'll need to take care of in WordPress.
So this is good to go, thanks a lot! 👍
Description
This removes "allfile-query", "filesystem-autocomplete", "filesystem-query" and "graphiql-filesystem" from
dictionary.txt
. These terms occurred in both thesourcing-from-the-filesystem.md
andtutorial/part-five/index.md
files, so both these files were edited to remove these terms. The terms were found in alt text values, so they were replaced with more descriptive phrases.Documentation
No documentation required for this change.
Related Issues
Addresses #25290.