Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/dev-404-page/ search and limit #13344

Merged
merged 3 commits into from
Apr 27, 2019

Conversation

quinnmcphail
Copy link
Contributor

@quinnmcphail quinnmcphail commented Apr 13, 2019

Description

Limits the number of links rendered to 100. Adds search functionality.
Initial
search
moreResults

Related Issues

Fixes #13204 although needs to be updated before #13186 merges.

@quinnmcphail quinnmcphail requested a review from a team as a code owner April 13, 2019 22:35
@KyleAMathews
Copy link
Contributor

Could you post a screenshot? Thanks for jumping on this!

@quinnmcphail
Copy link
Contributor Author

Sure! I added them to the initial comment for visibility.

@quinnmcphail quinnmcphail force-pushed the topics/dev-404-update branch from 729c4d9 to 675ff8b Compare April 17, 2019 06:30
@quinnmcphail
Copy link
Contributor Author

Works with the graphql refactor from #13186.

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks!

@KyleAMathews KyleAMathews merged commit 1a3e9f9 into gatsbyjs:master Apr 27, 2019
@gatsbot
Copy link

gatsbot bot commented Apr 27, 2019

Holy buckets, @quinnmcphail — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit number of results on dev 404 page and add search
2 participants