This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Configuration option to remove page listing from developer 404 page #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe instead of config flag we could adjust dev 404 page:
|
|
@pieh can loki do basic search? Adding the filtering support into graphql directly would be nice |
|
@pieh @KyleAMathews I found that even just doing a splice would fix the problem and adding simple pagination - the issue I'm finding with a site that has well over 500k pages is that just the DOM work is what's dragging it down. I have a feature branch ready to pull - do you want a PR or should this be discussed further in the RFC? |
|
Related: gatsbyjs/gatsby#13204 |
|
This got merged so I'm going to close this RFC gatsbyjs/gatsby#13344 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been running into issues where sites with over 100,000 pages cause the developer 404 page to either stop, or consume a lot of resources. This simple RFP adds a configuration variable to remove that listing.
Not sure if this warrants an entire RFC. 🤷♀️