Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-recipes): While apply a step, show the time elapsed after 10 seconds #23362

Merged
merged 2 commits into from
Apr 23, 2020
Merged

feat(gatsby-recipes): While apply a step, show the time elapsed after 10 seconds #23362

merged 2 commits into from
Apr 23, 2020

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Apr 21, 2020 •
edited
Loading

closes #23360

Screen Shot 2020-04-21 at 3 52 29 PM

@KyleAMathews KyleAMathews requested a review from a team as a code owner April 21, 2020 21:51
@shannonbux
Copy link
Contributor

Some thoughts:

  • what will the word "elapsed" change to after 10s? I'm thinking just delete it and leave the total seconds it took?
  • If the point of this is to give feedback to users that the process is indeed running and isn't stuck or frozen, I think starting at 10 seconds just updating with each second would give smooth feedback. So it'd go from 10 to 11 to 12, etc. Not sure what increments you're thinking of. I think 1s would be great

@shannonbux shannonbux mentioned this pull request Apr 22, 2020
Closed
15 tasks
@KyleAMathews
Copy link
Contributor Author

I'm copying the Terraform UI here — they just keep it at 10s elapsed until 20 seconds go by when it's 20s elapsed and so on — I think this makes sense as some resources can take a while to create/update — so a slower update cycle vs. every second makes sense. Perhaps :-)

johno
johno approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕰️

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Apr 23, 2020
@gatsbybot gatsbybot merged commit e42e8e0 into master Apr 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the recipes-elapsed branch April 23, 2020 18:52
pvhee added a commit to marzeelabs/gatsby that referenced this pull request Apr 24, 2020
@pvhee
Merge branch 'master' of github.com:gatsbyjs/gatsby
cc513b5 
* 'master' of github.com:gatsbyjs/gatsby: (64 commits)
  Fix recipe test problems (gatsbyjs#23347)
  create blog post announcing extended deadline for Virtual Gatsby Days… (gatsbyjs#23430)
  Correct CFP deadline date on Virtual Gatsby Days registration announcement (gatsbyjs#23432)
  fix(gatsby-recipes): Raise an error when an unknown resource is used (gatsbyjs#23428)
  feat(gatsby-recipes): While apply a step, show the time elapsed after 10 seconds (gatsbyjs#23362)
  markdownASTToHTMLAst isn't async (gatsbyjs#23427)
  Be more vocal about not doing type checking (gatsbyjs#23397)
  docs(gatsby-remark-images): mark `sizeByPixelDensity` as deprecated (gatsbyjs#23387)
  chore(all): Improve renovate (gatsbyjs#23411)
  chore(gatsby): count sift hits in telemetry (gatsbyjs#23416)
  chore(showcase): add GeneOS and COVID KPI (gatsbyjs#23405)
  feat(analytics): defer google analytics script (gatsbyjs#22806)
  docs: mention passing the .tsx file to createPage (gatsbyjs#23329)
  fix(www): tweak docsearch to init algolia when tabbed into (gatsbyjs#23040)
  chore(docs): Fix typo in url (gatsbyjs#23394)
  chore(gatsby-preset-gatsby-package): Remove tsconfig.json (gatsbyjs#23388)
  fix(gatsby-recipes): link to the raw gist of .estlintrc.js (gatsbyjs#23390)
  docs: Create gitlab-continuous-integration.md (gatsbyjs#23367)
  chore(doc): switch zeit now to Vercel Now for Gatsby deployment (gatsbyjs#23346)
  chore(showcase): add Resume on the Web (gatsbyjs#23371)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johno johno johno approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the UI when the apply step has taken longer than 10 seconds
6 participants
@KyleAMathews @shannonbux @johno @lannonbr @sidharthachatterjee @gatsbybot