chore(gatsby): count sift hits in telemetry #23416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to know how frequent the fast indexes fail to find anything when they're actually supposed to find something. This is currently not tracked and leads to skewed results. By counting how frequent Sift finds something when fast indexes fail or bail, we can get more relevant insight into how well fast indexes are actually performing, and/or whether we need to start thinking about eliminating Sift altogether. tbd.
freiksenet
previously approved these changes
Apr 23, 2020
pvhee
added a commit
to marzeelabs/gatsby
that referenced
this pull request
Apr 24, 2020
* 'master' of github.com:gatsbyjs/gatsby: (64 commits) Fix recipe test problems (gatsbyjs#23347) create blog post announcing extended deadline for Virtual Gatsby Days… (gatsbyjs#23430) Correct CFP deadline date on Virtual Gatsby Days registration announcement (gatsbyjs#23432) fix(gatsby-recipes): Raise an error when an unknown resource is used (gatsbyjs#23428) feat(gatsby-recipes): While apply a step, show the time elapsed after 10 seconds (gatsbyjs#23362) markdownASTToHTMLAst isn't async (gatsbyjs#23427) Be more vocal about not doing type checking (gatsbyjs#23397) docs(gatsby-remark-images): mark `sizeByPixelDensity` as deprecated (gatsbyjs#23387) chore(all): Improve renovate (gatsbyjs#23411) chore(gatsby): count sift hits in telemetry (gatsbyjs#23416) chore(showcase): add GeneOS and COVID KPI (gatsbyjs#23405) feat(analytics): defer google analytics script (gatsbyjs#22806) docs: mention passing the .tsx file to createPage (gatsbyjs#23329) fix(www): tweak docsearch to init algolia when tabbed into (gatsbyjs#23040) chore(docs): Fix typo in url (gatsbyjs#23394) chore(gatsby-preset-gatsby-package): Remove tsconfig.json (gatsbyjs#23388) fix(gatsby-recipes): link to the raw gist of .estlintrc.js (gatsbyjs#23390) docs: Create gitlab-continuous-integration.md (gatsbyjs#23367) chore(doc): switch zeit now to Vercel Now for Gatsby deployment (gatsbyjs#23346) chore(showcase): add Resume on the Web (gatsbyjs#23371) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to know how frequent the fast indexes fail to find anything when they're actually supposed to find something. This is currently not tracked and leads to skewed/incomplete results. By counting how frequent Sift finds something when fast indexes fail or bail, we can get more relevant insight into how well fast indexes are actually performing, and/or whether we need to start thinking about eliminating Sift altogether to prevent having to fall back on it for empty sets. tbd.