Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): convert components to typescript #24045

Merged
merged 7 commits into from
May 18, 2020
Merged

chore(gatsby): convert components to typescript #24045

merged 7 commits into from
May 18, 2020

Conversation

Kornil
Copy link
Contributor

@Kornil Kornil commented May 13, 2020 •
edited
Loading

Convert src/redux/reducers/components.ts to TypeScript.

Related Issues

#21995

@Kornil Kornil requested a review from a team as a code owner May 13, 2020 07:54
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 13, 2020
@blainekasten blainekasten mentioned this pull request May 13, 2020
Closed
@wardpeet wardpeet added status: awaiting author response Additional information has been requested from the author and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 13, 2020
@Kornil
Copy link
Contributor Author

Kornil commented May 13, 2020

Thank you for the reviews, I addressed all feedback!

@Kornil Kornil requested review from pieh and hiwelo May 13, 2020 12:07
hiwelo
hiwelo reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@hiwelo hiwelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing our feedback. That's a nice PR! ✌️
One was maybe just left out 👍

packages/gatsby/src/redux/reducers/index.js Outdated Show resolved Hide resolved
@Kornil Kornil requested a review from hiwelo May 13, 2020 13:00
hiwelo
hiwelo previously approved these changes May 13, 2020
View reviewed changes
@hiwelo hiwelo added status: needs core review Currently awaiting review from Core team member and removed status: awaiting author response Additional information has been requested from the author labels May 13, 2020
@Kornil Kornil mentioned this pull request May 15, 2020
Merged
@pieh pieh self-assigned this May 15, 2020
pieh
pieh approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you both @Kornil for PR and @hiwelo for nice and actionable reviews!

@pieh pieh merged commit 6450af2 into gatsbyjs:master May 18, 2020
@Kornil Kornil deleted the typescript-gatsby-redux-reducers-components branch May 18, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

@hiwelo hiwelo hiwelo left review comments

Assignees

@pieh pieh

Labels
status: needs core review Currently awaiting review from Core team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kornil @pieh @hiwelo @wardpeet