Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): convert babelrc to typescript #24115

Merged
merged 14 commits into from
May 18, 2020

Conversation

Kornil
Copy link
Contributor

@Kornil Kornil commented May 15, 2020

Convert src/redux/reducers/babelrc.ts and relative test file to TypeScript.

Related Issues

#21995

@Kornil Kornil requested a review from a team as a code owner May 15, 2020 11:48
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 15, 2020
@Kornil Kornil changed the title Typescript gatsby reducer babel chore(gatsby): convert babelrc to typescript May 15, 2020
Kornil and others added 11 commits May 15, 2020 15:02
…yjs#24108)

* Guard against possibly missing context in resolver

* Warn about bad resolver invocations

* Add warning

* Update packages/gatsby/src/schema/resolvers.ts

Co-authored-by: Ward Peeters <ward@coding-tech.com>

* Fix typo

Co-authored-by: Ward Peeters <ward@coding-tech.com>
 - gatsby-admin@0.1.32
 - gatsby-theme-blog-core@1.5.7
 - gatsby-theme-blog@1.6.7
 - gatsby-theme-notes@1.3.33
 - gatsby-theme-ui-preset@0.0.22
 - gatsby@2.21.32
 - gatsby-admin@0.1.33
 - gatsby-theme-blog-core@1.5.8
 - gatsby-theme-blog@1.6.8
 - gatsby-theme-notes@1.3.34
 - gatsby-theme-ui-preset@0.0.23
 - gatsby@2.21.33
@Kornil Kornil force-pushed the typescript-gatsby-reducer-babel branch from 462a07c to d314a1e Compare May 15, 2020 13:02
@Kornil Kornil requested a review from a team as a code owner May 15, 2020 13:02
@Kornil Kornil changed the base branch from master to cli/typescript/reducer May 15, 2020 13:07
@Kornil Kornil changed the base branch from cli/typescript/reducer to master May 15, 2020 13:07
@Kornil
Copy link
Contributor Author

Kornil commented May 15, 2020

I did a little bit of a mess with creating the branch off the wrong branch (my own #24045) but ran a rebase to clean things up. It polluted the commit list with 4 commits from master, but they do not affect the PR.

Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 18, 2020
@gatsbybot gatsbybot merged commit f3269e9 into gatsbyjs:master May 18, 2020
@Kornil Kornil deleted the typescript-gatsby-reducer-babel branch May 18, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants