Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(gatsby): enable fast filters for in comparator #24095

Merged
merged 1 commit into from
May 15, 2020
Merged

perf(gatsby): enable fast filters for in comparator #24095

merged 1 commit into from
May 15, 2020

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented May 14, 2020

This enables fast filters for the in comparator. This means this doesn't have to go through Sift for most of the cases.

@pvdz pvdz requested a review from a team as a code owner May 14, 2020 15:47
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 14, 2020
@pvdz pvdz added scaling topic: GraphQL Related to Gatsby's GraphQL layer topic: performance Related to runtime & build performance and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 14, 2020
@pvdz pvdz marked this pull request as draft May 14, 2020 16:09
@pvdz pvdz marked this pull request as ready for review May 15, 2020 10:51
@pvdz pvdz merged commit 70a7533 into master May 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the fast-in branch May 15, 2020 11:36
@pvdz
Copy link
Contributor Author

pvdz commented May 15, 2020

Published in gatsby@2.21.33

Kornil pushed a commit to Kornil/gatsby that referenced this pull request May 15, 2020
gatsbybot pushed a commit that referenced this pull request May 18, 2020
* Initial conversion

* Add ISetBabelPluginAction

* Fix naming

* Add missing actions

* Add missing plugin type

* Convert babelrc test file to TS

* COnvert snap file as well

* fix(gatsby): Protect about possibly missing context in graphql (#24108)

* Guard against possibly missing context in resolver

* Warn about bad resolver invocations

* Add warning

* Update packages/gatsby/src/schema/resolvers.ts

Co-authored-by: Ward Peeters <ward@coding-tech.com>

* Fix typo

Co-authored-by: Ward Peeters <ward@coding-tech.com>

* chore(release): Publish

 - gatsby-admin@0.1.32
 - gatsby-theme-blog-core@1.5.7
 - gatsby-theme-blog@1.6.7
 - gatsby-theme-notes@1.3.33
 - gatsby-theme-ui-preset@0.0.22
 - gatsby@2.21.32

* perf(gatsby): enable fast filters for `in` comparator (#24095)

* chore(release): Publish

 - gatsby-admin@0.1.33
 - gatsby-theme-blog-core@1.5.8
 - gatsby-theme-blog@1.6.8
 - gatsby-theme-notes@1.3.34
 - gatsby-theme-ui-preset@0.0.23
 - gatsby@2.21.33

Co-authored-by: Mikhail Novikov <freiksenet@gmail.com>
Co-authored-by: Ward Peeters <ward@coding-tech.com>
Co-authored-by: Peter van der Zee <209817+pvdz@users.noreply.github.com>
Co-authored-by: Peter van der Zee <github-public@qfox.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: GraphQL Related to Gatsby's GraphQL layer topic: performance Related to runtime & build performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants