Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning in docs before bumping master branch #24538

Merged
merged 7 commits into from
Jun 10, 2020
Merged

Warning in docs before bumping master branch #24538

merged 7 commits into from
Jun 10, 2020

Conversation

Ildarik
Copy link
Contributor

@Ildarik Ildarik commented May 27, 2020

Fix #24479

@Ildarik Ildarik requested a review from a team as a code owner May 27, 2020 15:20
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 27, 2020
@vladar vladar added status: needs dx review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 27, 2020
marcysutton
marcysutton suggested changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for the PR! I left some grammatical suggestions, including one that prevented the site from building properly. Let us know if you have any questions.

docs/docs/how-gatsby-works-with-github-pages.md Outdated Show resolved Hide resolved
docs/docs/how-gatsby-works-with-github-pages.md Outdated Show resolved Hide resolved
docs/docs/how-gatsby-works-with-github-pages.md Outdated Show resolved Hide resolved
docs/docs/how-gatsby-works-with-github-pages.md Outdated Show resolved Hide resolved
docs/docs/how-gatsby-works-with-github-pages.md Outdated Show resolved Hide resolved
Ildarik and others added 5 commits June 6, 2020 08:08
@Ildarik
Update docs/docs/how-gatsby-works-with-github-pages.md
ea88196 
Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
@Ildarik
Update docs/docs/how-gatsby-works-with-github-pages.md
d3feea0 
Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
@Ildarik
Update docs/docs/how-gatsby-works-with-github-pages.md
f96d783 
Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
@Ildarik
Update docs/docs/how-gatsby-works-with-github-pages.md
93cfd41 
Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
@Ildarik
Update docs/docs/how-gatsby-works-with-github-pages.md
c8e3f4c 
Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
marcysutton
marcysutton approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR!

@marcysutton marcysutton merged commit 5d980e3 into gatsbyjs:master Jun 10, 2020
@gatsbot
Copy link

gatsbot bot commented Jun 10, 2020

Holy buckets, @Ildarik — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@Ildarik Ildarik deleted the docs/24479 branch June 10, 2020 20:09
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
Warning in docs before bumping master branch (gatsbyjs#24538)
e20df11 
* Close gatsbyjs#24479

* chore: format

* Update docs/docs/how-gatsby-works-with-github-pages.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/how-gatsby-works-with-github-pages.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/how-gatsby-works-with-github-pages.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/how-gatsby-works-with-github-pages.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

* Update docs/docs/how-gatsby-works-with-github-pages.md

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>

Co-authored-by: Marcy Sutton <marcy@gatsbyjs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcysutton marcysutton marcysutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need warning in docs about bumping master branch during deployment to gh pages
3 participants
@Ildarik @marcysutton @vladar