Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): webpack warnings are no longer in object format by default #30801

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Apr 10, 2021

Fixes #30780

Related: facebook/create-react-app#9943

You can use a canary version of Gatsby with this fix by installing gatsby@webpack-split-fix

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 10, 2021
@@ -128,7 +128,8 @@ module.exports = async function build(program: IBuildArgs): Promise<void> {
stats = await buildProductionBundle(program, buildActivityTimer.span)

if (stats.hasWarnings()) {
reportWebpackWarnings(stats.compilation.warnings, report)
const rawMessages = stats.toJson({ moduleTrace: false })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this restores the object format from webpack 4

@KyleAMathews
Copy link
Contributor Author

Hmmm Typescript problems sigh

kamit-transient added a commit to kamit-transient/temp_gatsby_fix that referenced this pull request Apr 10, 2021
@vladar vladar added topic: webpack/babel Webpack or babel and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 11, 2021
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick, thank you! 🚢

@vladar vladar merged commit 33415c8 into master Apr 12, 2021
@vladar vladar deleted the warnings-to-json branch April 12, 2021 17:12
vladar pushed a commit that referenced this pull request Apr 13, 2021
…lt (#30801)

* fix(gatsby): webpack warnings are no longer in object format by default

* Fix (maybe) Typescript errors

(cherry picked from commit 33415c8)
vladar pushed a commit that referenced this pull request Apr 13, 2021
…lt (#30801) (#30853)

* fix(gatsby): webpack warnings are no longer in object format by default

* Fix (maybe) Typescript errors

(cherry picked from commit 33415c8)

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: webpack/babel Webpack or babel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'split' of undefined
2 participants