Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): webpack warnings are no longer in object format by default #30801

Merged
merged 2 commits into from
Apr 12, 2021
Merged

fix(gatsby): webpack warnings are no longer in object format by default #30801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d6f6d6
fix(gatsby): webpack warnings are no longer in object format by default
KyleAMathews Apr 10, 2021
e2a17ca
Fix (maybe) Typescript errors
KyleAMathews Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/gatsby/src/commands/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ module.exports = async function build(program: IBuildArgs): Promise<void> {
stats = await buildProductionBundle(program, buildActivityTimer.span)

if (stats.hasWarnings()) {
reportWebpackWarnings(stats.compilation.warnings, report)
const rawMessages = stats.toJson({ moduleTrace: false })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this restores the object format from webpack 4

reportWebpackWarnings(rawMessages.warnings, report)
}
} catch (err) {
buildActivityTimer.panic(structureWebpackErrors(Stage.BuildJavascript, err))
Expand Down
3 changes: 2 additions & 1 deletion packages/gatsby/src/services/start-webpack-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ export async function startWebpackServer({

if (webpackActivity) {
if (stats.hasWarnings()) {
reportWebpackWarnings(stats.compilation.warnings, report)
const rawMessages = stats.toJson({ moduleTrace: false })
reportWebpackWarnings(rawMessages.warnings, report)
}

if (!isSuccessful) {
Expand Down
4 changes: 2 additions & 2 deletions packages/gatsby/src/utils/webpack-error-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Reporter } from "gatsby-cli/lib/reporter/reporter"
import { WebpackError, Module, NormalModule } from "webpack"
import { WebpackError, StatsCompilation, Module, NormalModule } from "webpack"
import { Stage as StageEnum } from "../commands/types"
import formatWebpackMessages from "react-dev-utils/formatWebpackMessages"

Expand Down Expand Up @@ -145,7 +145,7 @@ export const structureWebpackErrors = (
}

export const reportWebpackWarnings = (
warnings: Array<WebpackError>,
warnings: StatsCompilation["warnings"] = [],
reporter: Reporter
): void => {
const warningMessages = warnings.map(warning => warning.message)
Expand Down