-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTF-next: Generate GraphQL schema based on Contentful Content Types #30855
base: master
Are you sure you want to change the base?
Conversation
What do you think about adding a Or should we make Tags a separate Node? |
@itwasmattgregg I'd like to duplicate the pattern the Contentful GraphQL API implements this new feature. To keep reviews doable, please keep in mind that this will be in a follow up PR |
6e07482
to
58f039a
Compare
67f316c
to
fb57bae
Compare
fb57bae
to
50d6ba2
Compare
08522e7
to
e498203
Compare
6a445eb
to
ddea54d
Compare
cccee87
to
4656166
Compare
…us of version overlap with current branch and this rewrite)
… they are now dev dependencies already
Published new alpha version - |
…y Rich Text references
Published new alpha version - |
add new flag for nodes from external sources to prevent unnecessary data loops --------- Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
We published new alpha versions:
|
👋 Long time plugin user here, nice progress! Just to add context on the necessity of getting this PR merged: I started a discussion on the potential workarounds I need to do to get a site working that has a restricted content model ID, where I'm confident that this PR could solve my problems in a better way than the alternatives I can think of. #38908 |
Discussion for the upcoming major release: #38585
Note for reviewers:
This adds schema generation to the gatsby-source-contentful plugin. This will remove the most annoying restriction of the plugin: You now can have fields without a single instance in your content model and your GraphQL will no more fail because of this. See: https://www.gatsbyjs.com/plugins/gatsby-source-contentful/#restrictions-and-limitations
Goals
__typename
andcontentful
on root levelThere are conflicting field types in your data.
warning and allows the JSON data structure to be changed in Contentful without breaking the Gatsby GraphQL Querygatsby-transformer-remark
relies on it. Lets discuss later on.sys
property (solved in refactor: reintroduce contentful sys commen resource attribute #31007)update gatsby-remark-images-contentful to match new asset structureno changes neededPerformance improvements
JSON.stringify()
and rich text renderer no more needs toJSON.parse()
Upcoming goals in the next major / Follow up PRs:
See #31385
Migration steps / Breaking changes
See #31385 (comment) for the full list of steps to migrate.