-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reintroduce contentful sys commen resource attribute #31007
Merged
axe312ger
merged 9 commits into
feat/contentful-schema-generation
from
refactor/contentful-schema-generic-sys
Apr 29, 2021
Merged
refactor: reintroduce contentful sys commen resource attribute #31007
axe312ger
merged 9 commits into
feat/contentful-schema-generation
from
refactor/contentful-schema-generic-sys
Apr 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axe312ger
added
breaking change
If implemented, this proposed work would break functionality for older versions of Gatsby
topic: source-contentful
Related to Gatsby's integration with Contentful
labels
Apr 22, 2021
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Apr 22, 2021
This includes code from #31008 and is blocked thill the other one is merged & this one rebased |
17 tasks
axe312ger
commented
Apr 22, 2021
axe312ger
commented
Apr 22, 2021
axe312ger
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Apr 22, 2021
axe312ger
force-pushed
the
feat/contentful-schema-generation
branch
from
April 27, 2021 07:30
135a5c5
to
08522e7
Compare
axe312ger
force-pushed
the
refactor/contentful-schema-generic-sys
branch
from
April 27, 2021 07:30
30405f3
to
70937e1
Compare
axe312ger
force-pushed
the
feat/contentful-schema-generation
branch
from
April 27, 2021 07:33
08522e7
to
e498203
Compare
axe312ger
force-pushed
the
refactor/contentful-schema-generic-sys
branch
from
April 27, 2021 07:34
70937e1
to
4a1301a
Compare
axe312ger
commented
Apr 27, 2021
packages/gatsby-source-contentful/src/download-contentful-assets.js
Outdated
Show resolved
Hide resolved
axe312ger
commented
Apr 27, 2021
axe312ger
added a commit
that referenced
this pull request
Apr 29, 2021
axe312ger
added a commit
that referenced
this pull request
Apr 29, 2021
axe312ger
added a commit
that referenced
this pull request
May 5, 2021
axe312ger
added a commit
that referenced
this pull request
May 12, 2021
axe312ger
added a commit
that referenced
this pull request
May 20, 2021
axe312ger
added a commit
that referenced
this pull request
May 20, 2021
axe312ger
added a commit
that referenced
this pull request
Jun 10, 2021
axe312ger
added a commit
that referenced
this pull request
Jul 12, 2021
axe312ger
added a commit
that referenced
this pull request
Jul 21, 2021
axe312ger
added a commit
that referenced
this pull request
Nov 18, 2021
axe312ger
added a commit
that referenced
this pull request
Jan 6, 2022
axe312ger
added a commit
that referenced
this pull request
Jan 14, 2022
axe312ger
added a commit
that referenced
this pull request
Feb 2, 2022
axe312ger
added a commit
that referenced
this pull request
Mar 9, 2022
axe312ger
added a commit
that referenced
this pull request
Apr 14, 2022
axe312ger
added a commit
that referenced
this pull request
May 17, 2022
axe312ger
added a commit
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
If implemented, this proposed work would break functionality for older versions of Gatsby
topic: source-contentful
Related to Gatsby's integration with Contentful
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #30855 and introduces the following changes:
One side effect of this change is that we later can remove the Contentful SDK link resolution. This will lead to performance improvements and code simplification (https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-source-contentful/src/gatsby-node.js#L446-L492)
(Breaking) Changes
Metadata / Data from
sys
Sorting
becomes
Filtering
becomes
Rich Text fields
references
subfield, not matter if they are linked or notreferences
instead of fields within each referenced content typeJSON fields
Spaces within keys of JSON fields are now kept.
becomes