-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby, gatsby-source-contentful): add public action to disable stale node checks #37782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Mar 24, 2023
TylerBarnes
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Mar 24, 2023
TylerBarnes
commented
Mar 25, 2023
TylerBarnes
commented
Mar 25, 2023
TylerBarnes
commented
Mar 25, 2023
TylerBarnes
added
the
topic: data
Relates to source-nodes, internal-data-bridge, and node creation
label
Mar 25, 2023
TylerBarnes
commented
Mar 29, 2023
TylerBarnes
commented
Mar 29, 2023
TylerBarnes
commented
Mar 29, 2023
TylerBarnes
commented
Mar 29, 2023
pieh
reviewed
Mar 29, 2023
pieh
reviewed
Apr 4, 2023
pieh
approved these changes
Apr 5, 2023
This was referenced Apr 6, 2023
2 tasks
This was referenced May 13, 2024
This was referenced May 13, 2024
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: data
Relates to source-nodes, internal-data-bridge, and node creation
topic: source-contentful
Related to Gatsby's integration with Contentful
topic: source-plugins
Relates to the Gatsby source plugins (e.g. -filesystem)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with #37780 (+ more changes I'll pr soon) this allows a 4.9M node Contentful site, that used to need 64Gi memory, build with only 24Gi memory.
The previous code blocked the event loop and loaded all nodes into memory. Memory quickly grew linearly (similar to my comment in the linked PR). With these changes memory usage stays more flat, but also being able to opt out entirely makes stale node checks much faster. With contentful there are so many nodes where
getNode
needs to be called to get the parent node and check if it's stale and that's really slow/costly.New api: