fix(gatsby): allow touching nodes owned by another plugin #38235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: core
LekoArts
changed the title
pieh
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
This looks like it actually restore previous behavior. Previously touchNode would only set local variable typeOwners based on touched node's .internal.owner but would not actually try to validate it. Now type ownership is just preserved between builds so not checking it here restores previous behavior as much as possible.
pieh
pushed a commit
that referenced
this pull request
Jun 15, 2023
allow touching nodes owned by another plugin (cherry picked from commit 5ec74c1)
LekoArts
pushed a commit
that referenced
this pull request
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like in #37782 type owners check was added to the
TOUCH_NODEaction which is likely causing this issue. I tried this PR locally on a repro from the linked issue and it seemed to resolve it.canary available as
gatsby@5.11.0-touch-nodes-fix.4Related issues
Fixes #38117