[gatsby-plugin-sharp] re: make width optional for fixed and fluid images #7520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6970.
It turns out transformer-sharp was setting default values anyway at the GraphQL level.
Also, the actual processing of the file when no width is provided was wrong, as it was calling
sharp.resize(NaN, height)and throwing.I did not add tests because I did not figure out a clean way to test
processFile. I'm open to suggestions.Also, I've noticed that the code has a lot of instances of
if (args.intValue), which might cause unexpected behavior whenintValueis0. In this case it probably won't matter since it makes no sense to resize an image to size 0.