[gatsby-transformer-sharp] Remove the width/maxWidth default values #7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsby-plugin-sharp can now calculate the image's width based on its height but for that the work the default values need to be removed
Windvis
changed the title
|
Just checking here - in your description "[this pr]" refers to #7671 ? |
|
O woops, yes I forgot to include the link 😶 My bad 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of this commit gatsby-plugin-sharp can now calculate the image's width based on its height but for that the work the default values need to be removed.
I chose to simply remove the values since
gatsby-plugin-sharpadds default values when both width and height aren't set (and the same goes for maxWidth/maxHeight).Fixes: #7663
Note: This depends on the changes in this pr to work. Otherwise the width will be set to NaN and Sharp will throw an error.