Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation for gz- alises #1

Merged
merged 3 commits into from
May 17, 2022
Merged

Initial implementation for gz- alises #1

merged 3 commits into from
May 17, 2022

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented May 16, 2022 •
edited
Loading

Tested Build Status

@j-rivero j-rivero mentioned this pull request May 16, 2022
Merged
@j-rivero
Copy link
Contributor Author

Merging to get early testing in this first migrated package

@j-rivero j-rivero merged commit b484f47 into main May 17, 2022
@j-rivero j-rivero deleted the gz_alias branch May 17, 2022 22:35
chapulina
chapulina reviewed May 24, 2022
View reviewed changes
ubuntu/debian/watch
@@ -1,4 +1,4 @@
version=4
opts="filenamemangle=s%(?:.*?)?v?(\d[\d.]*)\.tar\.gz%@PACKAGE@-$1.tar.gz%" \
https://github.com/ignitionrobotics/ign-cmake/tags \
https://github.com/gazebosim/ign-cmake/tags \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL won't work, we need to change the ign- as well

@chapulina chapulina mentioned this pull request May 24, 2022
Closed
17 tasks
@chapulina
Copy link
Contributor

I'm seeing downstream CI failures related to this:

Errors were encountered while processing:
 /tmp/apt-dpkg-install-BrLOxH/0-libgz-cmake3-dev_2.999.999+nightly+git20220524+1r946a27aec230d12f234406bb69177c34b0af510e-1~focal_amd64.deb

https://build.osrfoundation.org/job/ignition_common-ci-pr_any-ubuntu_auto-amd64/1294/console

scpeters added a commit that referenced this pull request May 26, 2022
@scpeters
Revert "Merge pull request #1 from gazebo-release/gz_alias"
34dc8e1 
This reverts commit b484f47, reversing
changes made to 4b42468.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request May 26, 2022
@scpeters
Revert "Merge pull request #1 from gazebo-release/gz_alias" (#2)
afca297 
This reverts commit b484f47, reversing
changes made to 4b42468.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this pull request May 26, 2022
Merged
@scpeters
Copy link
Contributor

I reverted this in #2 and will follow up by testing these changes with ign-launch6 and gz-sim7

@scpeters scpeters mentioned this pull request May 26, 2022
Merged
@chapulina chapulina mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-rivero @chapulina @scpeters