Add script to rename packages from ignition to gazebo #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-rivero
force-pushed
the
rename_ign_to_gz
branch
from
646da9b to
6c6ef57
Compare
j-rivero
force-pushed
the
rename_ign_to_gz
branch
from
1b4cf75 to
b1754cc
Compare
chapulina
reviewed
May 24, 2022
There was a problem hiding this comment.
I just tried installing CMake3 and it looks like it did the right thing pulling the gz package!
$ sudo apt install libignition-cmake3-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
libgz-cmake3-dev
The following NEW packages will be installed:
libgz-cmake3-dev libignition-cmake3-dev
0 upgraded, 2 newly installed, 0 to remove and 12 not upgraded.
Need to get 187 kB of archives.
After this operation, 1,895 kB of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 http://packages.osrfoundation.org/gazebo/ubuntu-nightly focal/main amd64 libgz-cmake3-dev amd64 2.999.999+nightly+git20220524+1r946a27aec230d12f234406bb69177c34b0af510e-1~focal [185 kB]
Get:2 http://packages.osrfoundation.org/gazebo/ubuntu-nightly focal/main amd64 libignition-cmake3-dev all 2.999.999+nightly+git20220524+1r946a27aec230d12f234406bb69177c34b0af510e-1~focal [1,676 B]
Fetched 187 kB in 0s (439 kB/s)
Selecting previously unselected package libgz-cmake3-dev:amd64.
(Reading database ... 474750 files and directories currently installed.)
Preparing to unpack .../libgz-cmake3-dev_2.999.999+nightly+git20220524+1r946a27aec230d12f234406bb69177c34b0af510e-1~focal_amd64.deb ...
Unpacking libgz-cmake3-dev:amd64 (2.999.999+nightly+git20220524+1r946a27aec230d12f234406bb69177c34b0af510e-1~focal) ...
Selecting previously unselected package libignition-cmake3-dev.
Preparing to unpack .../libignition-cmake3-dev_2.999.999+nightly+git20220524+1r946a27aec230d12f234406bb69177c34b0af510e-1~focal_all.deb ...
Unpacking libignition-cmake3-dev (2.999.999+nightly+git20220524+1r946a27aec230d12f234406bb69177c34b0af510e-1~focal) ...
Setting up libgz-cmake3-dev:amd64 (2.999.999+nightly+git20220524+1r946a27aec230d12f234406bb69177c34b0af510e-1~focal) ...
Setting up libignition-cmake3-dev (2.999.999+nightly+git20220524+1r946a27aec230d12f234406bb69177c34b0af510e-1~focal) ...
| echo "Changeing watch file ${f}" | ||
| sed -i -e 's:/osrf/:/ignitionrobotics/:g' "${f}" | ||
| sed -i -e 's:ignitionrobotics:gazebosim:g' "${f}" | ||
| sed -i -e 's:ignition:gz:g' "${f}" |
There was a problem hiding this comment.
I think we also need a sed -i -e 's:ign:gz:g' "${f}" here, to fix URLs like this:
| @@ -101,11 +101,6 @@ if [ -z ${ENABLE_REAPER} ]; then | |||
| ENABLE_REAPER=true | |||
| fi | |||
|
|
|||
| # We use ignitionsrobotics or osrf. osrf by default | |||
| if [ -z ${GITHUB_ORG} ]; then | |||
| GITHUB_ORG="osrf" | |||
There was a problem hiding this comment.
Do we need osrf for Gazebo classic?
| @@ -48,7 +48,7 @@ if ${NIGHTLY_MODE}; then | |||
| if ${USE_REPO_DIRECTORY_FOR_NIGHTLY}; then | |||
| mv ${WORKSPACE}/repo \$REAL_PACKAGE_NAME | |||
| else | |||
| git clone https://github.com/${GITHUB_ORG}/\$REAL_PACKAGE_NAME -b ${NIGHTLY_SRC_BRANCH} | |||
| git clone https://github.com/gazebosim/\$REAL_PACKAGE_NAME -b ${NIGHTLY_SRC_BRANCH} | |||
There was a problem hiding this comment.
I think we still need osrf for Gazebo classic
|
Run for |
17 tasks
Signed-off-by: Louise Poubel <louise@openrobotics.org>
|
This script is very handy! A lot has changed in the release repos since this PR was opened. So I've been using a modified version of it to open various PRs. |
Imported changes in a32c867 |
|
Merging to archive the work done. The script probably will need some tweaks if used in the future but I think it is a good resource to have in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress. First run on gz-cmake3 gazebo-release/gz-cmake3-release#1