Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for renaming script in 726 #797

Closed
wants to merge 3 commits into from

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Aug 22, 2022

Following up comment in #726

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@@ -11,11 +11,6 @@ find . -name control -type f | while IFS= read -r f; do
fi
done

# we don't support buster anymore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to remove it?

@@ -49,43 +50,14 @@ EOF
echo
done

# 2. Copyright files
find . -name '*copyright*' -type f | while IFS= read -r f; do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright updates were generating problems?

done

# 3. Test file if needed
if [[ -f ubuntu/debian/tests/ ]]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the autokpgtest :(

echo
fi

# 4. Changelog files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not working?

find . -name '*ignition*' -type f | while IFS= read -r f; do
echo "Renaming ${f} -> ${f/ignition-/gz-}"
git mv "${f}" "${f/ignition-/gz-}"
done

# 6. watch files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep watch files are not very useful for us but did they generate any problem?

@j-rivero j-rivero changed the title Updates for renaming in script in 726 Updates for renaming script in 726 Aug 22, 2022
@j-rivero
Copy link
Contributor Author

j-rivero commented Sep 7, 2022

Closing. Import a subset of this PR in a32c867

@j-rivero j-rivero closed this Sep 7, 2022
@scpeters scpeters deleted the chapulina/rename_ign_to_gz branch November 19, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants