-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import terminal dashboard from Louise. Display versions #426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements! I'm leaving comments with feature requests, with the full understanding that we may not be able to address them anytime soon 😅
Right now, if there's any version released for an architecture, that shows up as green. For example, see ign-math
:
At a quick glance, one may think that the latest release succeeded for all platforms, but in fact, if you look closely, Focal::armhf and Buster::arm64 still have 6.7.0. It would be helpful to show older versions in a different color, so we know that the latest release failed for those archs.
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
I agree. Some of the features you are proposing are hard to get them right using bash and would probably require a bit of real programming (like getting different colors for different versions). Before we spent more time on this, we probably want to revisit #295 . My proposal would be to leave it as-it is or with some small changes and merge and focus efforts on #295. |
Hardcode all collections Signed-off-by: Louise Poubel <louise@openrobotics.org>
@j-rivero , I took the liberty of pushing some updates directly in c717e2b:
The only outstanding issue is that the collections (i.e. I think we should start using this, it's useful already! Current results: $ bash table.bash citadel$ bash table.bash dome$ bash table.bash edifice |
I just imported the terminal dashboard used by Louise during the releases and modify it to display the versions available. Nothing solid since it needs a lot of parametrization and use of gazebodistro probably. Left in draft by now: