Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import terminal dashboard from Louise. Display versions #426

Merged
merged 6 commits into from
Sep 11, 2021

Conversation

j-rivero
Copy link
Contributor

I just imported the terminal dashboard used by Louise during the releases and modify it to display the versions available. Nothing solid since it needs a lot of parametrization and use of gazebodistro probably. Left in draft by now:

image

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements! I'm leaving comments with feature requests, with the full understanding that we may not be able to address them anytime soon 😅


Right now, if there's any version released for an architecture, that shows up as green. For example, see ign-math:

image

At a quick glance, one may think that the latest release succeeded for all platforms, but in fact, if you look closely, Focal::armhf and Buster::arm64 still have 6.7.0. It would be helpful to show older versions in a different color, so we know that the latest release failed for those archs.

terminal-dashboard/table.bash Outdated Show resolved Hide resolved
terminal-dashboard/table.bash Outdated Show resolved Hide resolved
j-rivero and others added 2 commits June 3, 2021 11:34
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
@j-rivero
Copy link
Contributor Author

j-rivero commented Jun 3, 2021

Thanks for the improvements! I'm leaving comments with feature requests, with the full understanding that we may not be able to address them anytime soon sweat_smile

I agree. Some of the features you are proposing are hard to get them right using bash and would probably require a bit of real programming (like getting different colors for different versions). Before we spent more time on this, we probably want to revisit #295 . My proposal would be to leave it as-it is or with some small changes and merge and focus efforts on #295.

@chapulina
Copy link
Contributor

chapulina commented Aug 27, 2021

@j-rivero , I took the liberty of pushing some updates directly in c717e2b:

  • Assuming bionic amd64 to be the reference version, we color other versions yellow in case they're different.
  • It's now possible to choose any collection to display

The only outstanding issue is that the collections (i.e. ignition-citadel) don't seem to have Source: packages, so they're never found.

I think we should start using this, it's useful already!

Current results:

$ bash table.bash citadel

image

$ bash table.bash dome

image

$ bash table.bash edifice

image


https://github.com/osrf/buildfarmer/issues/224

@chapulina chapulina marked this pull request as ready for review August 27, 2021 01:21
@chapulina chapulina merged commit 9cdc6e6 into master Sep 11, 2021
@chapulina chapulina deleted the terminal_louise_dashboard branch September 11, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants