Fix dashboard to include packages without Source field (i.e ignition-fortress) #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-rivero
changed the title
chapulina
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #505 . The reason because is not working in not really that we are not providing source packages for ignition-$collections but that is not mandatory to include a
Source:clause in .deb packages. My hypothesis is: when there is a single binary package with the same name than the source package, theSource:field is omitted. This is the case for our ignition-$collection packages.The PR is changing the previous
grep:grep -1 "Source: ${LIB}"By:
grep -1 -m 1 -e "Source: ${LIB}" -e "Package: ${LIB}"Adding
-m 1should make grep to stop on the first match (side effect, this can speed up the script). If we don't find theSource:field we fallback to look for thePackage: