Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the comparison sheets #61

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Update the comparison sheets #61

merged 3 commits into from
Aug 25, 2020

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Aug 18, 2020

I've reorganized the comparison sheet to express what SDF features are currently supported. I added info about missing closed kinematic chain support and a few more things.

@peci1 peci1 requested a review from maryaB-osr as a code owner August 18, 2020 09:38
@peci1
Copy link
Contributor Author

peci1 commented Aug 18, 2020

Please, rather check all the checkmarks/crosses, they're just my best guess.

Also, I saw a checkmark near "Custom sensors" in Gazebo-classic (and Ignition Gazebo, too). What is meant by that? AFAIK the SDF spec doesn't allow any sensors except those explicitly mentioned in the <sensor type> attribute.

@peci1 peci1 mentioned this pull request Aug 18, 2020
Open
@peci1
Copy link
Contributor Author

peci1 commented Aug 18, 2020

It's also highly probable that there are more SDF features I haven't identified which would be worth mentioning here.

chapulina
chapulina reviewed Aug 20, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting the time into this! I just have some small comments.

blueprint/comparison.md Outdated Show resolved Hide resolved
blueprint/comparison.md Outdated Show resolved Hide resolved
blueprint/comparison.md Outdated Show resolved Hide resolved
blueprint/comparison.md Outdated Show resolved Hide resolved
@chapulina chapulina self-assigned this Aug 20, 2020
@chapulina chapulina added documentation Improvements or additions to documentation 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint labels Aug 20, 2020
@chapulina
Copy link
Contributor

I saw a checkmark near "Custom sensors" in Gazebo-classic (and Ignition Gazebo, too). What is meant by that?

Yeah that's a mistake, see https://github.com/ignitionrobotics/docs/pull/26/files#diff-9c8d54780a3947049a188bad343dabd2R39

@peci1 @chapulina
Apply suggestions from code review
420838a 
Co-authored-by: Louise Poubel <louise@openrobotics.org>
@peci1
Copy link
Contributor Author

peci1 commented Aug 24, 2020

Thanks for the corrections. I've accepted all of them.

How about the line with custom sensors that is fixed in #26? The PR doesn't seem like something that would get merged soon, but at least the correction of the line with custom sensors would deserve to be applied soon.

@chapulina
Copy link
Contributor

How about the line with custom sensors that is fixed in #26? The PR doesn't seem like something that would get merged soon

I'll put some time into that PR soon

@chapulina chapulina merged commit 893d98f into gazebosim:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@maryaB-osr maryaB-osr Awaiting requested review from maryaB-osr

Assignees

@chapulina chapulina

Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peci1 @chapulina