-
Notifications
You must be signed in to change notification settings - Fork 498
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Just FYI, #2734 changes how models are spawned from |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
I added the [Wrn] [SystemPaths.cc:464] File or path does not exist [""] [meshes/test.dae]
[Err] [Visual.cc:3043] No mesh specified |
@chapulina, I added these lines and there is no segfault:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some comments
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested locally too
There are way too many failing tests, I'll take a look at them next week. |
I think the windows build is failing since this was merged:
|
Closes #2718 .
The main motivation for this is to allow more models to be reused between Gazebo-classic and Ignition to ease migration. Comments on this issue are relevant: gazebosim/gz-fuel-tools#77 (comment). I'm planning to document all this on a proper tutorial once the implementation is in.
This is a port of this ign-gazebo PR.
What's working
I locally modified the Dumpster model to use relative URIs for visual and collision geometries, as well as materials. Then I verified that it's possible to insert it from the left menu and both client and server load all assets correctly.
TODO
~/factory
withsdf_filename
works