Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build: filesystem #2839

Merged
merged 2 commits into from
Sep 5, 2020
Merged

Fix Windows build: filesystem #2839

merged 2 commits into from
Sep 5, 2020

Conversation

chapulina
Copy link
Contributor

I was too worried about test failures on #2765 that I didn't notice one of the builds was completely broken, sorry about that. This is an attempt at a fix.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment. can we use only one target_link_libraries ?

gazebo/common/CMakeLists.txt Show resolved Hide resolved
@ahcorde
Copy link
Contributor

ahcorde commented Sep 4, 2020

I can't see the build results. The server is not responding.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added 11 Gazebo 11 bug Something isn't working os::windows labels Sep 4, 2020
@scpeters
Copy link
Member

scpeters commented Sep 5, 2020

@chapulina chapulina merged commit ca55c6e into gazebo11 Sep 5, 2020
@chapulina chapulina deleted the chapulina/win/fs branch September 5, 2020 00:21
GoncaloLeao pushed a commit to GoncaloLeao/gazebo that referenced this pull request Nov 27, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Gazebo 11 bug Something isn't working os::windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants