Initialize default shadow caster name in Scene #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shadow caster name in the Scene is empty if the ignition transport service call fails, so initialize it to the default value. Follow up to gazebosim#3048. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
WilliamLewww
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #3048, we can now specify the name of a shadow caster material to be used in a scene. This is parsed from the SDFormat world file by
gazebo::physics::Worldand exposed togazebo::rendering::Sceneby an ion-transport service. If the service call fails, however, theScenedoes not have a valid name for the shadow caster material. This sets the default value for the shadow caster material name in theSceneto match the default value in World.cc.