Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wide-angle lens flare occlusion lag #3325

Merged
merged 12 commits into from
May 25, 2023
Merged

Fix wide-angle lens flare occlusion lag #3325

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a43e4a3
Add model to illustrate lens flare lag issue
scpeters Mar 30, 2023
1e6570c
Force update of wide angle dummy camera
audrow May 17, 2023
1207519
Wrap at 80 characters
audrow May 17, 2023
118cd87
Merge branch 'gazebo11' into scpeters/lens-flare-occlusion-lag
scpeters May 19, 2023
36b9a71
Fix indentation in world file
scpeters May 19, 2023
14dce26
Existing test: get sensor by scoped name
scpeters May 19, 2023
35bd97c
Add test for occlusion lag
scpeters May 19, 2023
29fedbe
Merge remote-tracking branch 'audrow/audrow/fix-lens-flare-delay' int…
scpeters May 19, 2023
627e8b3
Merge pull request #3 from gazebosim/scpeters/lens-flare-occlusion-lag
audrow May 19, 2023
eb81028
Use expect near in image equality checks
audrow May 19, 2023
29dbe5a
Try to robustify image waiting
scpeters May 22, 2023
032247e
Fix test flakiness with --lockstep
scpeters May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gazebo/rendering/LensFlare.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ namespace gazebo
ignition::math::Pose3d(
Conversions::ConvertIgn(cam->getDerivedPosition()),
Conversions::ConvertIgn(quat)));
this->dataPtr->wideAngleDummyCamera->OgreCamera()->getParentSceneNode()->_update(true, true);
Copy link
Contributor

@iche033 iche033 May 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wrap line to 80 chars

Copy link
Contributor Author

@audrow audrow May 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 1207519.


// OcclusionScale() was built for a regular perspective projection
// camera and cannot be passed a WideAngleCamera. A cleaner solution
Expand Down