[ign-common3] Improve fork experience #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-common3 #103 +/- ##
============================================
Coverage 73.97% 73.97%
============================================
Files 69 69
Lines 9421 9421
============================================
Hits 6969 6969
Misses 2452 2452 Continue to review full report at Codecov.
|
mjcarroll
changed the title
chapulina
added
🏢 edifice
mjcarroll
approved these changes
Oct 16, 2020
Yeah, it can probably be included in #104 |
|
@osrf-jenkins retest this please |
mjcarroll
added a commit
that referenced
this pull request
Oct 26, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
added a commit
that referenced
this pull request
Oct 27, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
added a commit
that referenced
this pull request
Oct 29, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Michael Carroll <michael@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our GitHub actions haven't been running correctly for forks. This should fix all of them:
CI
CI only on
pushmeans that PRs from forks aren't tested. Addingpull_requestfixes forks, with the downside of triggering duplicated jobs for PRs coming from branches in this repo.Also removed the codecov token for the Focal builds because we only need to upload coverage reports once, and this causes failures sometimes.
Labeler
Resolves gazebo-tooling/pr-collection-labeler#4.
Uses the new pull_request_target event.
Tested here: gazebosim/testing#14
Triage
Like above, uses the new pull_request_target event.
Tested here: gazebosim/testing#15