Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with PRs from forks #4

Closed
chapulina opened this issue Sep 10, 2020 · 1 comment
Closed

Make it work with PRs from forks #4

chapulina opened this issue Sep 10, 2020 · 1 comment

Comments

@chapulina
Copy link
Contributor

The GitHub token provided with PRs from forks doesn't have enough permissions for labeling. The actions API also doesn't allow us injecting a valid token from the secrets.

Until recently, I thought we needed to use a polling strategy like on gazebosim/docs#75 to assign these labels. It's less immediate and uses more resources, but it seemed to be what people were doing everywhere. Until recently GitHub announced the new pull_request_target event that should be helpful here.

For completeness, I started working on a polling solution a while back but never finished:

master...chapulina/periodic

@chapulina
Copy link
Contributor Author

The pull_request_target even works like a charm. Tested here: gazebosim/testing#14

Now I need to open PRs for alllll repositories to use it 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant