Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fork experience #66

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Improve fork experience #66

merged 1 commit into from
Oct 26, 2020

Conversation

chapulina
Copy link
Contributor

Our GitHub actions haven't been running correctly for forks. This should fix all of them:

CI

CI only on push means that PRs from forks aren't tested. Adding pull_request fixes forks, with the downside of triggering duplicated jobs for PRs coming from branches in this repo.

Also removed the codecov token for the Focal builds because we only need to upload coverage reports once, and this causes failures sometimes.

Labeler

Resolves gazebo-tooling/pr-collection-labeler#4.

Uses the new pull_request_target event.

Tested here: gazebosim/testing#14

Triage

Like above, uses the new pull_request_target event.

Tested here: gazebosim/testing#15

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from nkoenig as a code owner October 14, 2020 21:23
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #66 into ign-launch2 will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-launch2      #66      +/-   ##
===============================================
+ Coverage        28.03%   28.15%   +0.11%     
===============================================
  Files                3        3              
  Lines              724      721       -3     
===============================================
  Hits               203      203              
+ Misses             521      518       -3     
Impacted Files Coverage Δ
src/vendor/backward.hpp 9.06% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2789cd...bd41d5b. Read the comment docs.

@chapulina chapulina added the 🏰 citadel Ignition Citadel label Oct 14, 2020
@chapulina chapulina mentioned this pull request Oct 14, 2020
@chapulina chapulina self-assigned this Oct 19, 2020
@chapulina chapulina merged commit cf4fc4e into ign-launch2 Oct 26, 2020
@chapulina chapulina deleted the chapulina/2/forkX branch October 26, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants