Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fork experience #126

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Improve fork experience #126

merged 1 commit into from
Oct 22, 2020

Conversation

chapulina
Copy link
Contributor

Our GitHub actions haven't been running correctly for forks. This should fix all of them:

CI

CI only on push means that PRs from forks aren't tested. Adding pull_request fixes forks, with the downside of triggering duplicated jobs for PRs coming from branches in this repo.

Also removed the codecov token for the Focal builds because we only need to upload coverage reports once, and this causes failures sometimes.

And removed the redundant ci-bionic workflow.

Labeler

Resolves gazebo-tooling/pr-collection-labeler#4.

Uses the new pull_request_target event.

Tested here: gazebosim/testing#14

Triage

Like above, uses the new pull_request_target event.

Tested here: gazebosim/testing#15

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from nkoenig as a code owner October 14, 2020 21:18
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #126 into ign-fuel-tools4 will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools4     #126      +/-   ##
===================================================
+ Coverage            76.80%   77.12%   +0.31%     
===================================================
  Files                   19       19              
  Lines                 2535     2535              
===================================================
+ Hits                  1947     1955       +8     
+ Misses                 588      580       -8     
Impacted Files Coverage Δ
src/WorldIter.cc 100.00% <0.00%> (+8.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bad7f2...d34ed3d. Read the comment docs.

@chapulina chapulina added the 🏰 citadel Ignition Citadel label Oct 14, 2020
@chapulina chapulina self-assigned this Oct 19, 2020
@chapulina chapulina merged commit da122ca into ign-fuel-tools4 Oct 22, 2020
@chapulina chapulina deleted the chapulina/4/forkX branch October 22, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants