Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fork experience #54

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Improve fork experience #54

merged 1 commit into from
Oct 27, 2020

Conversation

chapulina
Copy link
Contributor

Our GitHub actions haven't been running correctly for forks. This should fix all of them:

CI

CI only on push means that PRs from forks aren't tested. Adding pull_request fixes forks, with the downside of triggering duplicated jobs for PRs coming from branches in this repo.

Also removed the redundant ci-bionic workflow.

Labeler

Resolves gazebo-tooling/pr-collection-labeler#4.

Uses the new pull_request_target event.

Tested here: gazebosim/testing#14

Triage

Like above, uses the new pull_request_target event.

Tested here: gazebosim/testing#15

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from iche033 as a code owner October 14, 2020 21:28
@chapulina chapulina added the 🏰 citadel Ignition Citadel label Oct 14, 2020
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #54 into ign-sensors3 will increase coverage by 15.72%.
The diff coverage is 60.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ign-sensors3      #54       +/-   ##
=================================================
+ Coverage         61.88%   77.61%   +15.72%     
=================================================
  Files                13       23       +10     
  Lines               942     2296     +1354     
=================================================
+ Hits                583     1782     +1199     
- Misses              359      514      +155     
Impacted Files Coverage Δ
include/ignition/sensors/Manager.hh 90.00% <ø> (ø)
src/GaussianNoiseModel.cc 98.30% <ø> (+42.12%) ⬆️
src/Manager.cc 81.08% <ø> (+43.34%) ⬆️
src/DepthCameraSensor.cc 74.05% <33.33%> (ø)
src/Noise.cc 73.33% <33.33%> (-1.67%) ⬇️
src/RgbdCameraSensor.cc 74.56% <33.33%> (ø)
src/ImageNoise.cc 43.47% <43.47%> (ø)
src/CameraSensor.cc 74.81% <52.63%> (ø)
src/ThermalCameraSensor.cc 57.01% <57.01%> (ø)
src/GpuLidarSensor.cc 88.31% <66.66%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e477d2...ed033b0. Read the comment docs.

@j-rivero
Copy link
Contributor

@osrf-jenkins run tests please

@chapulina chapulina merged commit 277c18f into ign-sensors3 Oct 27, 2020
@chapulina chapulina deleted the chapulina/3/forkX branch October 27, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants