Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make labeler work with PRs from forks #390

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Oct 14, 2020

Resolves gazebo-tooling/pr-collection-labeler#4

GitHub recently added the pull_request_target event, which makes this much easier. Unfortunately, this can't be fixed on the action itself, and needs to be done for each branch using it 😢

I tested that this makes the labeler work with forks here: gazebosim/testing#14

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from scpeters October 14, 2020 20:26
@scpeters scpeters merged commit 6094b9d into sdf9 Oct 15, 2020
@scpeters scpeters deleted the chapulina/9/labeler_forks branch October 15, 2020 00:11
scpeters pushed a commit to scpeters/sdformat that referenced this pull request Dec 14, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
scpeters pushed a commit to scpeters/sdformat that referenced this pull request Dec 15, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
scpeters pushed a commit that referenced this pull request Dec 15, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants