Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows doesn't support colons in filenames #106

Closed
chapulina opened this issue Aug 20, 2020 · 1 comment · Fixed by #376
Closed

Windows doesn't support colons in filenames #106

chapulina opened this issue Aug 20, 2020 · 1 comment · Fixed by #376
Labels
bug Something isn't working Windows Windows support

Comments

@chapulina
Copy link
Contributor

chapulina commented Aug 20, 2020

This makes several of our tests fail, because they try to create folders such as localhost:8001 in the local cache.

Example failure:

Failed to copy file [D:\Jenkins\workspace\ignition_fuel-tools-ci-pr_any-windows7-amd64\ws\ign-fuel-tools\build\test_cache\localhost:8007\alice\models\My Model\2\model.config] to [D:\Jenkins\workspace\ignition_fuel-tools-ci-pr_any-windows7-amd64\ws\ign-fuel-tools\build\test_cache\localhost:8007\alice\models\My Model\3\model.config]: The filename, directory name, or volume label syntax is incorrect.

We could just change the tests, but this would also be a problem for a user who actually needs a port number in their servers. This will also be a problem for model names containing colons.

So for now I'll disable these tests on Windows until we come up with a better solution.

@mjcarroll
Copy link
Contributor

Fixed by #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Windows Windows support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants