Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👩‍🌾 Make Windows 🟢 #107

Merged
merged 12 commits into from
Aug 25, 2020
Merged

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 20, 2020

Windows currently has 46 test failures and 25 warnings. With this PR, it has 0️⃣ and 0️⃣ : Build Status

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from nkoenig as a code owner August 20, 2020 22:55
@chapulina chapulina added tests Broken or missing tests / testing infra Windows Windows support labels Aug 20, 2020
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #107 into ign-fuel-tools3 will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools3     #107      +/-   ##
===================================================
+ Coverage            86.08%   86.14%   +0.05%     
===================================================
  Files                   19       19              
  Lines                 2221     2223       +2     
===================================================
+ Hits                  1912     1915       +3     
+ Misses                 309      308       -1     
Impacted Files Coverage Δ
...nclude/ignition/fuel_tools/CollectionIdentifier.hh 100.00% <ø> (ø)
include/ignition/fuel_tools/Model.hh 100.00% <ø> (ø)
include/ignition/fuel_tools/RestClient.hh 100.00% <ø> (ø)
include/ignition/fuel_tools/Result.hh 100.00% <ø> (ø)
src/FuelClient.cc 87.71% <100.00%> (-0.03%) ⬇️
src/Zip.cc 69.51% <100.00%> (+1.15%) ⬆️
src/ign.cc 85.42% <0.00%> (-0.34%) ⬇️
src/LocalCache.cc 80.12% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0571f4a...ecc8639. Read the comment docs.

Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@chapulina chapulina merged commit 987c333 into ign-fuel-tools3 Aug 25, 2020
@chapulina chapulina deleted the chapulina/win_tests branch August 25, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint tests Broken or missing tests / testing infra Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants