Bumps in garden: use ign-common5

[chapulina]

See gazebo-tooling/release-tools#574

[codecov]

Codecov Report

Merging #224 (8fe711d) into main (67af73e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   75.55%   75.55%           
=======================================
  Files          20       20           
  Lines        2757     2757           
=======================================
  Hits         2083     2083           
  Misses        674      674           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67af73e...8fe711d. Read the comment docs.

[scpeters]

@osrf-jenkins run tests please

[scpeters]

@osrf-jenkins run tests please

[scpeters]

some console output from one of the windows test failures, not sure if it's relevant:

[ RUN      ] FuelClientTest.CachedModel
5: [Dbg] [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\FuelClient_TEST.cc:48] Creating local model in [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\build\ignition-fuel_tools8]
5: [Wrn] [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\LocalCache.cc:105] Server directory does not exist [C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\build\ignition-fuel_tools8\test_cache\fuel.ignitionrobotics.org]
5: C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\FuelClient_TEST.cc(621): error: Value of: result
5:   Actual: false
5: Expected: true

[chapulina]

I opened a separate PR targeting Citadel with the test updates from 8fe711d:

• Improve and fix ResultType tests #225

[chapulina]

some console output from one of the windows test failures, not sure if it's relevant:

Thanks, I was looking for the error code in the test below:

5: �[mC:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\FuelClient_TEST.cc(621): error: Value of: result
5:   Actual: false
5: Expected: true
5: C:\Jenkins\workspace\ign_fuel-tools-pr-win\ws\ign-fuel-tools\src\FuelClient_TEST.cc(622): error: Expected equality of these values:
5:   ResultType::FETCH_ALREADY_EXISTS
5:     Which is: 4-byte object <05-00 00-00>
5:   result.Type()
5:     Which is: 4-byte object <07-00 00-00>

It's getting a FETCH_ERROR, I'll track where that can be coming from

[chapulina]

I think it's the colon on the directory paths (#204). Someone needs dig into this and solve it for all versions. There are inconsistencies on how fuel-tools and common handle this for different versions 😕

[chapulina]

Ok, so Windows has test failures on Edifice and Fortress, and the Windows check is not required on those branches. I think we should also remove the requirement for Garden, merge this, and when #106 is fixed for Edifice, the fix should be forward-ported and CI cleaned up.

What do you think, @scpeters ?

[chapulina]

I removed the requirement for Windows CI on main and updated

• Make CI checks required gazebo-tooling/release-tools#398.

I think this is ready!

[chapulina]

Merging this and its infrastructure PRs:

• Bumps in garden : ci_matching_branch/bump_garden_ign-fuel-tools8 gazebo-release/gz-fuel-tools8-release#2
• Bumps in garden: ign-fuel-tools8 use ign-common5 osrf/homebrew-simulation#1761
• Bumps in garden: ign-fuel-tools8 use common5, math7 gazebo-tooling/gazebodistro#69