Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More checks when manipulating file system in tests #227

Merged
merged 6 commits into from
Jan 11, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Dec 29, 2021

🎉 New feature

Summary

These checks are useful when debugging test failures. At a minimum, they allow us to rule-out these lines are reasons for the failure.

The changes consist in expecting true for these calls:

  • createDirectories
  • copyFile

This is motivated by debugging #224

Test it

CI should pass for all platforms

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the tests Broken or missing tests / testing infra label Dec 29, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Dec 29, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #227 (b6ba285) into ign-fuel-tools4 (3ea0844) will not change coverage.
The diff coverage is n/a.

❗ Current head b6ba285 differs from pull request most recent head a40d439. Consider uploading reports for the commit a40d439 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           ign-fuel-tools4     #227   +/-   ##
================================================
  Coverage            77.90%   77.90%           
================================================
  Files                   19       19           
  Lines                 2715     2715           
================================================
  Hits                  2115     2115           
  Misses                 600      600           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea0844...a40d439. Read the comment docs.

src/FuelClient_TEST.cc Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit ae90993 into ign-fuel-tools4 Jan 11, 2022
@chapulina chapulina deleted the chapulina/4/more_checks branch January 11, 2022 19:01
chapulina added a commit that referenced this pull request Mar 7, 2022
* Improve and fix ResultType tests (#225)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Move test cache to build folder (#222)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* More checks when manipulating file system in tests (#227)

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants