Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 ➡️ 5 #280

Merged
merged 6 commits into from
Sep 9, 2021
Merged

4 ➡️ 5 #280

merged 6 commits into from
Sep 9, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gui4 to ign-gui5

Branch comparison: ign-gui5...ign-gui4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

chapulina and others added 6 commits August 3, 2021 17:13
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 9, 2021
@chapulina chapulina requested a review from jennuine as a code owner September 9, 2021 00:25
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #280 (13c022a) into ign-gui5 (6cdc2f7) will not change coverage.
The diff coverage is n/a.

❗ Current head 13c022a differs from pull request most recent head dd3a844. Consider uploading reports for the commit dd3a844 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui5     #280   +/-   ##
=========================================
  Coverage     66.12%   66.12%           
=========================================
  Files            26       26           
  Lines          3218     3218           
=========================================
  Hits           2128     2128           
  Misses         1090     1090           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cdc2f7...dd3a844. Read the comment docs.

@chapulina chapulina merged commit 1cad501 into ign-gui5 Sep 9, 2021
@chapulina chapulina deleted the chapulina/4_to_5 branch September 9, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants