-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user camera FOV control in SDF files #400
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-gui6 #400 +/- ##
===========================================
Coverage ? 30.54%
===========================================
Files ? 41
Lines ? 1748
Branches ? 0
===========================================
Hits ? 534
Misses ? 1214
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, need some minor changes.
- Add the new element to the documentation here:
gz-gui/src/plugins/minimal_scene/MinimalScene.hh
Lines 46 to 63 in c1e7927
/// ## Configuration /// /// * \<engine\> : Optional render engine name, defaults to 'ogre'. If another /// engine is already loaded, that will be used, because only /// one engine is supported at a time currently. /// * \<scene\> : Optional scene name, defaults to 'scene'. The plugin will /// create a scene with this name if there isn't one yet. If /// there is already one, a new camera is added to it. /// * \<ambient_light\> : Optional color for ambient light, defaults to /// (0.3, 0.3, 0.3, 1.0) /// * \<background_color\> : Optional background color, defaults to /// (0.3, 0.3, 0.3, 1.0) /// * \<camera_pose\> : Optional starting pose for the camera, defaults to /// (0, 0, 5, 0, 0, 0) /// * \<camera_clip\> : Optional near/far clipping distance for camera /// * \<near\> : Camera's near clipping plane distance, defaults to 0.01 /// * \<far\> : Camera's far clipping plane distance, defaults to 1000.0 /// * \<sky\> : If present, sky is enabled.
In the PR description:
- Change
Closes
toPart of
as there are other parameters we want to add (Github will close the PR ifCloses
is present) - Update the 'Test it' portion to the correct sdf snippet as we discussed in the VC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks for iterating! One minor fix left and please fix the last 2 commits to include your sign-off so DCO will pass
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
7862059
to
8dba3b5
Compare
Signed-off-by: youhy <haoyuan2019@outlook.com>
Please fix the code check error: https://github.com/gazebosim/gz-gui/runs/6493033767?check_suite_focus=true#step:4:4561 |
Signed-off-by: youhy <haoyuan2019@outlook.com>
New feature
Part of gazebosim/gz-sim#421
Summary
Users can now change the FOV of the user camera in SDF as follows:
Test it
Please enter the FOV in degree and by default ignition uses a FOV of 90
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.