Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip pybind11 and SWIG #480

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Addresses gazebosim/gz-cmake#300

Summary

  • Adds SKIP_PYBIND11 to allow for Python binding generation to be skipped.
  • Adds SKIP_SWIG to allow for Ruby binding generation to be skipped.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 9, 2022
@mjcarroll mjcarroll self-assigned this Aug 9, 2022
@chapulina chapulina added the bug Something isn't working label Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #480 (9cdfe43) into gz-math7 (0a438f7) will not change coverage.
The diff coverage is n/a.

❗ Current head 9cdfe43 differs from pull request most recent head d122f90. Consider uploading reports for the commit d122f90 to get more accurate results

@@            Coverage Diff            @@
##           gz-math7     #480   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
=========================================
  Files            77       77           
  Lines          7007     7007           
=========================================
  Hits           6986     6986           
  Misses           21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit b257637 into gz-math7 Aug 10, 2022
@mjcarroll mjcarroll deleted the mjcarroll/skip_generators branch August 10, 2022 02:26
azeey pushed a commit that referenced this pull request Apr 5, 2023
Signed-off-by: Michael Carroll <michael@openrobotics.org>
scpeters pushed a commit that referenced this pull request Apr 6, 2023
Signed-off-by: Michael Carroll <michael@openrobotics.org>
danilogsch pushed a commit to danilogsch/gz-math that referenced this pull request Jun 1, 2023
Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll added a commit that referenced this pull request Aug 22, 2023
… models (#486)

* Class ignition::math::MecanumDriveOdometryPrivate to handle Mecanum wheels odometry

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update include/ignition/math/MecanumDriveOdometry.hh

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update include/ignition/math/MecanumDriveOdometry.hh

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update include/ignition/math/MecanumDriveOdometry.hh

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update src/MecanumDriveOdometry.cc

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* MecanumDrive doc

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* MecanumDrive doc

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update MecanumDriveOdometry.cc

line length corrections

* Update include/ignition/math/MecanumDriveOdometry.hh

* CI workflow: use checkout v3 (#519)

Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Rename COPYING to LICENSE (#521)

The LICENSE file contained a copy of the stanze
used at the top of source code files, while the
actual license was in the COPYING file. So remove
the stanza and put the actual Apache 2.0 license text
in LICENSE.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Custom PID error rate (#525)

* Custom PID error rate

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* added test

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

---------

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* Add option to skip pybind11 and SWIG (#480)

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Disable pybind11 on windows by default (#529)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* 🎈 6.14.0 (#531)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* Lint

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

* Port changes and tests from muttistefano

Co-authored-by: muttistefano <mutti.stefano.jp@gmail.com>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

* Add accessor and TODO note

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

---------

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Nate Koenig <natekoenig@gmail.com>
Co-authored-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai>
Co-authored-by: muttistefano <mutti.stefano.jp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants