Disable pybind11 on windows by default #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## azeey/cherrypick_480 #529 +/- ##
=====================================================
Coverage 99.68% 99.68%
=====================================================
Files 73 73
Lines 6918 6918
=====================================================
Hits 6896 6896
Misses 22 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
scpeters
pushed a commit
that referenced
this pull request
Apr 6, 2023
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
|
porting forward in #530 |
8 tasks
3 tasks
danilogsch
pushed a commit
to danilogsch/gz-math
that referenced
this pull request
Jun 1, 2023
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
8 tasks
mjcarroll
added a commit
that referenced
this pull request
Aug 22, 2023
… models (#486) * Class ignition::math::MecanumDriveOdometryPrivate to handle Mecanum wheels odometry Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com> * Update include/ignition/math/MecanumDriveOdometry.hh Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com> * Update include/ignition/math/MecanumDriveOdometry.hh Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com> * Update include/ignition/math/MecanumDriveOdometry.hh Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com> * Update src/MecanumDriveOdometry.cc Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com> * MecanumDrive doc Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com> * MecanumDrive doc Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com> * Update MecanumDriveOdometry.cc line length corrections * Update include/ignition/math/MecanumDriveOdometry.hh * CI workflow: use checkout v3 (#519) Version v2 of the actions/checkout workflow is deprecated, so switch to v3. Part of gazebo-tooling/release-tools#862. Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Rename COPYING to LICENSE (#521) The LICENSE file contained a copy of the stanze used at the top of source code files, while the actual license was in the COPYING file. So remove the stanza and put the actual Apache 2.0 license text in LICENSE. Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Custom PID error rate (#525) * Custom PID error rate Signed-off-by: Nate Koenig <natekoenig@gmail.com> * added test Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Add option to skip pybind11 and SWIG (#480) Signed-off-by: Michael Carroll <michael@openrobotics.org> * Disable pybind11 on windows by default (#529) Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * 🎈 6.14.0 (#531) Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Lint Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> * Port changes and tests from muttistefano Co-authored-by: muttistefano <mutti.stefano.jp@gmail.com> Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> * Add accessor and TODO note Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> --------- Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Nate Koenig <natekoenig@gmail.com> Signed-off-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Nate Koenig <natekoenig@gmail.com> Co-authored-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: muttistefano <mutti.stefano.jp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Our CI didn't have
pybind11installed, so the binding code wasn't being tested. Whenpybind11is actually installed, the MSVC compiler generates over 120 warnings and all the python related tests fail. The warnings have caused problems downstream (gazebo-release/gz_math6_vendor#4). This PR disabled pybind11 on windows by default until we fix the warnings and test failures.Needs #528
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.